Coming from #503444: $db_port for non-standard ports. Aegir supports nonstandard database ports in the UI, but I cannot specify a nonstandard port for the initial installation. Any advice?

If not, I'll roll a patch for it.

CommentFileSizeAuthor
#4 2069387_04.patch5.78 KBcweagans
#2 2069387_02.patch3.87 KBcweagans
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
CreditAttribution: ergonlogic commented

I came across this too last week, when working on #2048653: Errors installing on Ubuntu 12.04 via .debs. It was probably an oversight. Feel free to submit a patch. Please also update drush_provision_hostmaster_install_pre_validate(), which would then look almost exactly like Provision_Service_db_mysql::grant_host()

cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
CreditAttribution: cweagans commented
Status: Active » Needs review
FileSize
2069387_02.patch3.87 KB

So I have this working - sort of. The attached patch allows you to set the database port for the initial install, and if you use --backend-only, the server context is written with the right port. If I don't use --backend-only, the context is created with the default port and the virtualhost for the aegir frontend is created with the port that was passed in.

I'm not really sure why this is happening. Maybe you will know?

cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
CreditAttribution: cweagans commented

One other thing - if the server context is wrong, then this would break the provisioned site when a verify task is run, right?

cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
CreditAttribution: cweagans commented
FileSize
2069387_04.patch5.78 KB

Updated patch. Testing right now.

cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
CreditAttribution: cweagans commented

Okay, so this patch works as expected. However, hostmaster.profile hardcodes the database port, so this is needed too: #2074681: Ports are hardcoded in hostmaster.profile

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
CreditAttribution: ergonlogic commented
Title: Support nonstandard database port on hostmaster-install command » Support nonstandard ports on hostmaster-install command

m.stenta is currently working on allowing an http port other than 80. Since the required changes are essentially identical, let's generalize this issue to include both.

Work is being done in the 'temp' branch of http://github.com/mstenta/provision

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
CreditAttribution: ergonlogic commented
Category: feature » bug

Considering that we support alternative ports everywhere else, I believe this is a bug.

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
CreditAttribution: ergonlogic commented
Status: Needs review » Fixed

fixed in e66befcf48..3b5e35d083

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit e66befc on dev-drupal-8, 6.x-2.x, dev-ssl-ip-allocation-refactor, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x authored by cweagans, committed by ergonlogic: 
    Issue #2069387 by cweagans: Added Support nonstandard database port on...