From a short mailing with merlin it looks like it would took until end of spring to get a working D6 panels version out of the door. While i'd like to upgrade ASAP or with final to D6 - i started to port the older and less complex 1.x version to D6.

It looks like i'm on a good way today. What i've already done is the following:
1. fixed tons of E_ALL warnings
2. tons of code style issues
3. upgraded menu, list view, delete form, install, schema, etc

The most important part i need works. So i'm now able to use this interim solution, but i cannot add/edit new panels from admin section. I will wait for someone helping on http://drupal.org/node/206955 and after this is fixed i will try again to fix the edit page.

CommentFileSizeAuthor
#6 panels_D5_to_D6.patch216.86 KBhass
#6 panels-6.x-1.x.tar_.gz170.78 KBhass

Comments

hass’s picture

hass commented

Panels looks using some type of form hacks and i get many of this notices on the edit page. Does someone have a good idea what this notice should tell me?

# notice: Undefined index: #programmed in includes\form.inc on line 845.
# notice: Undefined index: #programmed in includes\form.inc on line 938.

merlinofchaos’s picture

merlinofchaos commented

When fixing code style issues, please do not fix any issues related to the concat operator (the dot). It's a Drupal code style convention I reject; I conform to it when working on core, but in my code I absolutely won't use it. Just so you know.

merlinofchaos’s picture

merlinofchaos commented

#programmed is a bit to tell the fapi that a form is a macro; i.e, it is coming from code, not from user input.

That notice may be a core bug.

hass’s picture

hass commented

Well, there are many concat operator fixes in... i would not turn this wheel back for now... i tried to make it notice/warning free to see the real errors and to get some bugs fixed :-). No harm to have this fixed for now and being core friendly isn't bad, too. Not checked the diff's yet how much this was, but i think something around 20-30.

#programmed: i thought this could be caused by the use of form_builder - i never worked with this yet. I will try to ignore this for now and figure out the last 4 warnings.

merlinofchaos’s picture

merlinofchaos commented

No, you misunderstand how seriously I object to that one piece of the coding standard. I won't commit code that uses that standard, any more than I will commit code that is improperly indented.

hass’s picture

hass commented
Assigned: » Unassigned
Status: Active » Needs work
StatusFileSize
new panels-6.x-1.x.tar_.gz170.78 KB
new panels_D5_to_D6.patch216.86 KB

Attached you get the current work in process version. It works in general if you have upgraded from D5 and like to get your old panels running. For me this works and is a level of interim solution until a final becomes available. I tried to fix the outstanding bugs, but don't get forward with them.

Already done / works:
1. Upgrade from D5 1.x version works.
2. List panels works.
3. (Edit)/View panels, without any change to content areas seems working.
4. Prior existing panels are loading as before (most important for me).
5. Add new panel selection works (1 step in adding a new panel).
6. Much cleanup / code style / commented some dead code.

Open Bugs:
1. Edit page gives some E_ALL notices
2. Add/Edit nodes, blocks, custom, etc to a panel is broken (no idea what's wrong here)
3. Add new panel is broken, could be related to the above bug
4. Some other E_ALL notices and warnings could be fixed.

If someone like to turn back the "concat operator" style, feel free to do so. I cannot turn this back, while i don't know much about merlins code style rules. Until there is no maintainers doc about this i will not spend any second on it and follow the drupal core rules. Doesn't matter to me if this patch get's committed or not. This patch is my (unfinished) workaround to upgrade my current running D5 box to D6 ASAP.

Maybe someone else could take a look inside and try to fix this hopeful small add/edit bugs. THX.

huayen’s picture

huayen commented

Great work!

Anyone ever tested this code? Need some feedbacks.

hass’s picture

hass commented

I'd like to say - i would remove the new update hook from this patch today... it's a required change for D6, but until we are not able to add new panels we don't need this change and may break the upgrade path from panels 5.x-2.x. I think the panels maintainer will not bear in mind my changes... i see my patch only as a workaround for running older and existing panels under D6.

The patch was much work, but it is not stable and needs work.

zilla’s picture

zilla commented

will this appear as 'testable' in two versions? eg. one with upgrade path, one without?
(subscribing)

hass’s picture

hass commented
Status: Needs work » Closed (won't fix)

We should port 2.x now.

vinothkumara’s picture

vinothkumara commented

I m getting this error when i try to add a panel

"warning: Invalid argument supplied for foreach() in C:\wamp\www\drupal-6.2\includes\form.inc on line 1181."

CAN ANYONE HELP ME????

hass’s picture

hass commented

This patch is not fully working! It works if you use pre-existing panels, but you cannot add new panels... this is why this patch "needs work". But for now - I would say - don't use it if you cannot fix this yourself. You should wait for the 6.x-2.x branch...

wuf31’s picture

wuf31 commented

subscribe.

mrfelton’s picture

mrfelton commented

subscribe