Notices when batch publishing a forum topic

The title wasn't informative of what is being accomplished here.

The use case: Errors when batch publishing a forum topic

The problem: Forum doesn't handle taxonomy term objects properly.

I've looked at the three lines of code and they accomplish a simple type change from object to int very nicely. Re-rolled patch against D7.

Is this code not tested in core? Does it sometimes get an int and sometimes an object? Marking to CNW since either one of those questions needs an answer before we commit this I think.

Just FYI, I've been unable to reproduce this problem.

Steps taken to try and reproduce the problem.

1. Enable forum module
2. Create a new forum for testing, admin/build/forum
3. Create a couple of new forum topics, mark them as un-published.
4. Navigate to admin/content/node, select the un-published forum topics and then publish them.

This was done on a clean install of Drupal HEAD.

Looking at the code I'm not sure that this is relevant for Drupal 7.

I was also unable to re-produce the error in Drupal 6.10

Can anyone confirm that this is still a problem? Can anyone provide detailed instructions as to how someone could reproduce the problem.

To find out how $node->taxonomy is handled in Drupal 7, the best reference is taxonomy's own saving function.

      if (is_array($term)) {
        foreach ($term as $tid) {
          if ($tid) {
            $query->values(array(
              'nid' => $node->nid,
              'vid' => $node->vid,
              'tid' => $tid,
            ));
          }
        }
      }
      elseif (is_object($term)) {
        $query->values(array(
          'nid' => $node->nid,
          'vid' => $node->vid,
          'tid' => $term->tid,
        ));
      }
      elseif ($term) {
        $query->values(array(
          'nid' => $node->nid,
          'vid' => $node->vid,
          'tid' => $term,
        ));
      }

As we can see, taxonomy itself codes for the possibility of each element of the $node->taxonomy array being either an object, an array of tids, or a tid. When loading node objects, taxonomy generates $node->taxonomy as an array of objects. (Note that $node->taxonomy['tags'] is a special array of [ int vid => string term-names ] for freetagging, which is processed and removed separately.)

It stands to reason that forum_node_presave will need to code for all of these cases. Unless we can show that some of these cases will never occur in the data that forum_node_presave is passed.

Here's a patch for 6.13 that should handle the 3 cases above. I've only found a test case for the first scenario (array of objects keyed by tid), so I'll need some help reviewing it for the other cases. In our case, it solved issues with the scheduler module. I'll try to get a patch for 7.x-dev as well.

Tested the 6.x version. Corrects the problem I was seeing... custom content types w/forum taxonomy now save properly when Scheduler publishes them (and appear in the forums).

Ok, here's a patch for 7.x-dev. To test this using only core modules, do this....

Enable Trigger and Forum core modules.
Assign the "Save post" action to the "After saving a new comment" trigger.
Create a forum container.
Create a forum inside that container.
Create a post in the forum.
Reply to the forum post with a comment.
Now try to view your post. It will be gone from the forum because it's record in the forum table has been deleted.

Again, I can only come up with a test case for the first scenario in the code. I can't think of situations where $node->taxonomy is a single term object, or single tid, but apparently they exist.

My bad... This should pass all tests.

I think one key difference is that one format comes from the form api, and another comes from db_fetch_object.