emfield.module line 413 is invoking emfield_widget_extra hook with only 2 arguments while emthumb_emfield_widget_extra() requires 4 arguments. This causes the warnings while editing emfield's configuration (and most likely prevents emthumb from functioning properly but I didn't have a time to test that at the moment).

$form[$field['field_name']][$delta][$module] = module_invoke($module, 'emfield_widget_extra', 'form', $data);

I'm not familiar with the emfield module code but by looking at the similar calls within the same function I guess it should probably be something like this:

$form[$field['field_name']][$delta][$module] = module_invoke($module, 'emfield_widget_extra', 'form', $node, $field, $data);

Comments

aaron’s picture

Assigned: Unassigned » aaron
Status: Active » Fixed

reading the code, looks like you're right. :P fixed and committed. i think that (or the last commit) may have been responsible for an extraneous node field i saw earlier when testing.

aaron

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.