GHOP task #128: Create tests for book [#207192]

create a new book
create a small hiearchy of pages in there
check the list of children links
check from a children test the next, prev, up links
check the printer friendly version of the book

Comment	File	Size	Author
#6	book_module2.test_.txt	5.35 KB	boombatower
#5	book_module.test	4.76 KB	Rok Žlender
#4	book_module.test_.txt	4.71 KB	boombatower
#3	book_module.test_.txt	4.77 KB	boombatower

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

chx CreditAttribution: chx commented 7 January 2008 at 08:29

Title:

Create tests for book

» GHOP task #128: Create tests for book

Comment #2

aclight CreditAttribution: aclight commented 7 January 2008 at 12:25

The GHOP task associated with this issue can be found at:
http://code.google.com/p/google-highly-open-participation-drupal/issues/...

Comment #3

boombatower CreditAttribution: boombatower commented 10 January 2008 at 05:27

Status:

Active

» Needs review

File	Size
book_module.test_.txt	4.77 KB

After allot of messing around to decide what worked and what didn't and what was the best way to do it I finally came up with the attached solution. I believe it meets all the requirements posted on GHOP.

Comment #4

boombatower CreditAttribution: boombatower commented 10 January 2008 at 21:32

File	Size
book_module.test_.txt	4.71 KB

Made a few changes, due to requests made on IRC:

Fixed name of class
Removed unnecessary permissions
Created two users: one to create book content, and one to view

Comment #5

Rok Žlender CreditAttribution: Rok Žlender commented 11 January 2008 at 16:18

Status:

Needs review

» Needs work

File	Size
book_module.test	4.76 KB

Tests look good and test everything we asked for. I made two changes to your file

Added setup function which is not needed but it is usually there for stuff like enabling modules or if you have few test functions that use same user perm you can put user creation in there
log out at the end is not needed, simpletest creates new browser session for every test function>

Before I mark this RTBC I'd like to see some documentation for your helper functions checkBookNode, generateOutlinePattern and createBookNode. Brief description of what function does, params and what does it return.