Download & Extend
SimpleTest » Issues

GHOP task #128: Create tests for book

Posted by chx on January 7, 2008 at 8:19am
Project:SimpleTest
Version:6.x-1.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:GHOP

Issue Summary

  • create a new book
  • create a small hiearchy of pages in there
  • check the list of children links
  • check from a children test the next, prev, up links
  • check the printer friendly version of the book
Login or register to post comments

Comments

#1

Posted by chx on January 7, 2008 at 8:29am
Title:Create tests for book» GHOP task #128: Create tests for book

#2

Posted by aclight on January 7, 2008 at 12:25pm

The GHOP task associated with this issue can be found at:
http://code.google.com/p/google-highly-open-participation-drupal/issues/...

#3

Posted by boombatower on January 10, 2008 at 5:27am
Status:active» needs review

After allot of messing around to decide what worked and what didn't and what was the best way to do it I finally came up with the attached solution. I believe it meets all the requirements posted on GHOP.

AttachmentSizeStatusTest resultOperations
book_module.test_.txt4.77 KBIgnored: Check issue status.NoneNone

#4

Posted by boombatower on January 10, 2008 at 9:32pm

Made a few changes, due to requests made on IRC:

  • Fixed name of class
  • Removed unnecessary permissions
  • Created two users: one to create book content, and one to view
AttachmentSizeStatusTest resultOperations
book_module.test_.txt4.71 KBIgnored: Check issue status.NoneNone

#5

Posted by Rok Žlender on January 11, 2008 at 4:18pm
Status:needs review» needs work

Tests look good and test everything we asked for. I made two changes to your file

  • Added setup function which is not needed but it is usually there for stuff like enabling modules or if you have few test functions that use same user perm you can put user creation in there
  • log out at the end is not needed, simpletest creates new browser session for every test function>

Before I mark this RTBC I'd like to see some documentation for your helper functions checkBookNode, generateOutlinePattern and createBookNode. Brief description of what function does, params and what does it return.

AttachmentSizeStatusTest resultOperations
book_module.test4.76 KBIgnored: Check issue status.NoneNone

#6

Posted by boombatower on January 11, 2008 at 10:12pm
Status:needs work» needs review

I believe I have made all the requested changes.

AttachmentSizeStatusTest resultOperations
book_module2.test_.txt5.35 KBIgnored: Check issue status.NoneNone

#7

Posted by Rok Žlender on January 12, 2008 at 10:10pm
Status:needs review» fixed

Thanks committed.

#8

Posted by Anonymous (not verified) on January 26, 2008 at 10:36pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

nobody click here