standardized xhtml code

I'm checking this for each provider. Here are the results of the first three providers:

YouTube
I get no warning related to the embed tag, as it should not be present in the latest version. However I do get errors for the following:
- The code for "&rel=0" needs to be changed to "&rel=0"
- The
tags that are not closed with need to have "/>" instead of ">" at the end of the tag, for example "
" should really be "
"

GoogleVideo
No errors

iFilm
- Multiple errors related to use of embed tag. I will check and see later whether the method used in the YouTube file can be used for this format.

Sorry, the first YouTube error needs to be changed to "&rel=0"

Blip.TV
- Multiple errors related to use of embed tag. I will check and see later whether the method used in the YouTube file can be used for this format.

Revver
* Quick note that only embed script is currently working for Revver, so I'll have to take a look into this as well.
- Validates as strict xhtml

BrightCove
- Multiple errors related to use of embed tag. I will check and see later whether the method used in the YouTube file can be used for this format.

Dailymotion
- - The tags that are not closed with need to have "/>" instead of ">" at the end of the tag, for example "<param name="allowFullScreen" value="true">" should really be "<param name="allowFullScreen" value="true" />"
I only now noticed that these tags were stripped out of the YouTube mention above, but it is the same error

MySpace
- Multiple errors related to use of embed tag. I will check and see later whether the method used in the YouTube file can be used for this format.

Jumpcut
* Not working at all for me.

LiveVideo
* Quick note that only embed script is currently working for LiveVideo, so I'll have to take a look into this as well.
- Multiple errors related to use of embed tag. I will check and see later whether the method used in the YouTube file can be used for this format.

MetaCafe
- Multiple errors related to use of embed tag. I will check and see later whether the method used in the YouTube file can be used for this format.

SevenLoad
- Multiple errors related to use of embed tag. I will check and see later whether the method used in the YouTube file can be used for this format.

I'll start going through these today to see if I can't make the A List Apart method work. On another note- why must these providers constantly change their codes! Ugh. ;-)

wow, thanks for all the research, alex! you rock! maybe we can find a way to standardize it across them as well as possible. i vaguely recall there's a module that helps out w/ that sort of thing, but don't remember its name right now. also, we might look into using the swfobject.js script.

aaron winborn

No problem! Vacation is over, so back to work for me! ;-)

I'll look into a flash module and/or the swfobject.js script, and yeah, we definitely should standardize this one way or another. I also wonder whether we might be able to use simpletest or some other module to automatically check the contrib files (would make checking for dead contribs a lot easier).

For now, here's a patch for youtube.inc, which validates as valid xhtml. It's my first rolled patch, so you should definitely check it first! ;-)

Yeah, thanks for the links- I actually got the youtube code from that article and will try and port the other files to it as well. The crazy thing (imo) is that all the sites in question use embed tags themselves. You'd figure they'd want as many people as possible to use their services, but I guess not...

I'm having problems with my CVS account- I can add new files but not update existing ones.

See: http://drupal.org/node/218060

As soon as my access gets corrected this will be committed.

Actually, nevermind, it was already committed. I'll try to go over the rest in the near future (after I get rid of some other RTBC stuff)

might be good to get this standardized before the final release. but if that's too much, it can wait till d6.

So far I have fixed both YouTube and Blip.TV so that they validate correctly. Will move on to the rest this weekend.

I also fixed DailyMotion

I tried to get iFilm and Brightcove to work with the ALA object method, but couldn't, do to the way they are feeding the flash to the player. If anyone has an idea on how to extract the information from these

On another note, I did find out that iFilm has changed its name to spike.com, and I changed the ifilm.inc file accordingly...

Remaining files to be tested and hopefully standardized before the move:
MySpace, Jumpcut, Livevideo, metacafe, sevenload, and possibly the hosted flash one...

I just fixed & committed MySpace to the devel version (with other patches for myspacetv.com and thumbnails)

aaron

I noticed that YouTube FINALLY stopped using embed for their embed code. they use the object tag instead. might want to look at that.

I take it back. Looks like they have it nested inside instead. not sure how that validates.

maybe the swftools module might be useful? looking at that right now.

Any update on this? Subscribing.

I've added support for another video provider using swfobject.

I tried to keep the changes as minimal as possible but had to add a drupal_load_js() in video_cck.module's hook_menu.

I'm wondering if this is the desired way to proceed and, if so:
- how do I get my provider support added to the module?
- I'll gladly start standardizing the other video provider includes so they all use swfobject.

On a legal note: swfobject is MIT-licensed, but #drupal let me know inclusion is permitted if certain copyright info is added.

Thanks.

That would be great. What provider have you been working on?

I finished GarageTV - www.garagetv.be (Belgium's largest online video host, I think), and I'm working on nr 2 as well (www.16plus.be).

I'll add a feature request for supporting garagetv and I'll include my provider include and the patch for cck_video, is that ok?

YouTube still doesn't validate for me:

Line 118, Column 194: cannot generate system identifier for general entity "enablejsapi"

…youtube.com/v/OKkKD_yoTbY&rel=0&enablejsapi=1&playerapiid=ytplayer&fs

Looksm like you've still got some incorrectly encoded ampersands in there (both enablejsapi and playerapiid). Ampersands must always be encoded as & in URLs:

http://www.htmlhelp.com/tools/validator/problems.html#amp

youtube should be okay now. thanks for the catch, seanr!

similar future reports should go to the respective provider modules.

If you want resolve problem with validation of xhtml (strict) code in emfield module for blip.tv provider

1. Go to sites modules directory:
sites/default/all/modules/emfield/contrib/emvideo/providers/

2. Open bliptv.inc and locate the line 323

$output .= '<embed src="http://blip.tv/play/'. $embed_code .'" type="application/x-shockwave-flash" width="'. $width .'" height="'. $height .'" allowscriptaccess="always" allowfullscreen="true"></embed>';

You can mark with // or replace

3. Replace with this code:

$output .= '<object classid="clsid:D27CDB6E-AE6D-11cf-96B8-444553540000" codebase="http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=6,0,40,0" width="' . $width .'" height="'. $height .'">
		<param name="movie" value="http://blip.tv/play/'. $embed_code . '" />
		<param name="quality" value="high" />
		<param name="bgcolor" value="#FFFFFF" />
		<param name="wmode" value="transparent" />
		<!--[if !IE]> <-->
		<object data="http://blip.tv/play/'. $embed_code.'" width="'. $width .'" height="'. $height .'" type="application/x-shockwave-flash">
		<param name="quality" value="high" />
		<param name="bgcolor" value="#FFFFFF" />
		<param name="pluginurl" value="http://www.adobe.com/go/getflashplayer" />
		FAIL (the browser should render some flash content, not this).
		</object>
		<!--> <![endif]-->
		</object>';

Tested on IE 8, FF3.5.x, Chrome, Safari and work well (no errors).

This is my first post. :)