When using the HEAD version of Zen with 6x-dev, I get the following notice on pages that display "local task" tabs:

notice: Undefined index: type in /web/test/sites/all/themes/zen/template-menus.php on line 20.

The attached patch is the way that I've fixed it temporarily (the notice goes away, and everything still seems to work) but I don't really know if this is the right way to do it.

CommentFileSizeAuthor
menu_notice.php_.txt862 byteskeith.smith

Comments

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Title: Notice in template-menus.php » Zen 6.x: PHP Notice in template-menus.php on pages with tabs
Status: Needs review » Reviewed & tested by the community

It's actually a bug in Drupal 6. The patch that fixes this issue is in the D6 issue queue: http://drupal.org/node/207029

I'm leaving this issue open until it gets fixed in Drupal core.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented

Keith, could you do me a favor and test the patch over at http://drupal.org/node/207029 and, if it works for you, mark it RTBC?

Since it's not a critical bug, nobody has reviewed it. :-( But it would be really nice if we could get the fix in before Drupal 6.0-rc3.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Status: Reviewed & tested by the community » Active
johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Status: Active » Fixed

The fix in http://drupal.org/node/207029 has been committed to Drupal 6, so it will be in Drupal 6.0-rc3.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.