Drewish, what do you think of grouping together the different image admin pages under admin/settings/, the same the station module does?
I have a patch if you think it's a good idea :)

CommentFileSizeAuthor
#15 image-DRUPAL-5--2.admin-paths.patch4.43 KBsun
#12 image_207340.patch4.52 KBdrewish
#11 image_admin_grouping_d6_again.patch4.48 KBjoachim
#8 image_admin_grouping.patch4.42 KBjoachim
#2 image_admin_grouping.patch3.51 KBjoachim

Comments

drewish’s picture

drewish commented

i like that style myself but sometimes it creates a bit of a support problem, people don't see the sub tabs. if i've got a patch go ahead and post it. we'll also need to update HEAD.

joachim’s picture

joachim commented
StatusFileSize
new image_admin_grouping.patch3.51 KB

Patch on the 5-2 branch.

Tweaked the names and descriptions a bit too.

joachim’s picture

joachim commented
Status: Active » Needs review

(oops. double post)

Hetta’s picture

Hetta commented

The patch applied (more or less), but it doesn't do anything. Does it matter that I'm on drupal 5.7?

joachim’s picture

joachim commented

You need to clear your cache. Easiest way to do that is with the Devel module.

Hetta’s picture

Hetta commented
Status: Needs review » Reviewed & tested by the community

Lovely, it applies cleanly, and works a treat!

drewish’s picture

drewish commented
Version: 5.x-2.x-dev » 6.x-1.x-dev
Status: Reviewed & tested by the community » Needs review

needs to happen in 6.x and then get backported...

joachim’s picture

joachim commented
StatusFileSize
new image_admin_grouping.patch4.42 KB

Here's a patch on CVS HEAD.

joachim’s picture

joachim commented

*bump*

I can commit this myself if it helps ... :)

drewish’s picture

drewish commented
Status: Needs review » Needs work

it doesn't apply cleanly in the image_import module... doesn't look like too big of a conflict. would you mind re-rolling it?

joachim’s picture

joachim commented
Status: Needs work » Needs review
StatusFileSize
new image_admin_grouping_d6_again.patch4.48 KB

Not at all :)

drewish’s picture

drewish commented
Status: Needs review » Fixed
StatusFileSize
new image_207340.patch4.52 KB

reverted the menu titles since they seemed inconsistent and it made it harder to figure out what had happened to each module's settings. committed attached to HEAD.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

joachim’s picture

joachim commented
Version: 6.x-1.x-dev » 5.x-2.x-dev
Status: Closed (fixed) » Reviewed & tested by the community

We forgot to backport this to 5. Marking as reviewed, per comment #6.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Fixed
StatusFileSize
new image-DRUPAL-5--2.admin-paths.patch4.43 KB

Committed attached patch to 5.x-2.x.

Note: Those changes (as well as the already existing menu code) contain unnecessary definitions - I've kept those for consistency.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.