group admin settings pages together

joachim - January 7, 2008 - 18:13
Project:Image
Version:6.x-1.x-dev
Component:image.module
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed
Description

Drewish, what do you think of grouping together the different image admin pages under admin/settings/, the same the station module does?
I have a patch if you think it's a good idea :)

#1

drewish - January 7, 2008 - 18:36

i like that style myself but sometimes it creates a bit of a support problem, people don't see the sub tabs. if i've got a patch go ahead and post it. we'll also need to update HEAD.

#2

joachim - January 7, 2008 - 22:35

Patch on the 5-2 branch.

Tweaked the names and descriptions a bit too.

AttachmentSize
image_admin_grouping.patch3.51 KB

#3

joachim - January 7, 2008 - 22:35
Status:active» patch (code needs review)

(oops. double post)

#4

Hetta - February 1, 2008 - 15:42

The patch applied (more or less), but it doesn't do anything. Does it matter that I'm on drupal 5.7?

#5

joachim - February 1, 2008 - 21:14

You need to clear your cache. Easiest way to do that is with the Devel module.

#6

Hetta - February 2, 2008 - 06:49
Status:patch (code needs review)» patch (reviewed & tested by the community)

Lovely, it applies cleanly, and works a treat!

#7

drewish - April 10, 2008 - 18:33
Version:5.x-2.x-dev» 6.x-1.x-dev
Status:patch (reviewed & tested by the community)» patch (code needs review)

needs to happen in 6.x and then get backported...

#8

joachim - April 11, 2008 - 13:31

Here's a patch on CVS HEAD.

AttachmentSize
image_admin_grouping.patch4.42 KB

#9

joachim - June 16, 2008 - 08:26

*bump*

I can commit this myself if it helps ... :)

#10

drewish - June 16, 2008 - 18:09
Status:patch (code needs review)» patch (code needs work)

it doesn't apply cleanly in the image_import module... doesn't look like too big of a conflict. would you mind re-rolling it?

#11

joachim - June 16, 2008 - 18:20
Status:patch (code needs work)» patch (code needs review)

Not at all :)

AttachmentSize
image_admin_grouping_d6_again.patch4.48 KB

#12

drewish - June 16, 2008 - 18:29
Status:patch (code needs review)» fixed

reverted the menu titles since they seemed inconsistent and it made it harder to figure out what had happened to each module's settings. committed attached to HEAD.

AttachmentSize
image_207340.patch4.52 KB

#13

Anonymous (not verified) - June 30, 2008 - 18:34
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.