Favicon has a square white background. It would look a lot better with a transparent background. I am unsure about how to patch this properly, so have attached fixed file here (only change is to make white transparent on both layers).
File to be patched is located at profiles/commons/themes/commons/commons_origins

CommentFileSizeAuthor
#3 use-transparent-favicon-2074179-3.patch4.24 KBdevin carlson
#3 favicon_comparison.png17.34 KBdevin carlson
#1 favicon.ico_.tar_.gz1.45 KBRustan

Comments

Rustan’s picture

Rustan commented
StatusFileSize
new favicon.ico_.tar_.gz1.45 KB

Uncompressed favicon was not accepted. Uploading again, compressed version.

ezra-g’s picture

ezra-g commented
Status: Active » Needs review
Issue tags: +Commons 7.x-3.4 radar

Thanks! Adding to our 3.4 radar.

devin carlson’s picture

devin carlson commented
Version: 7.x-3.3 » 7.x-3.x-dev
StatusFileSize
new favicon_comparison.png17.34 KB
new use-transparent-favicon-2074179-3.patch4.24 KB

+1 to a transparent background for the favicon.

The attached patch updates the favicon to use the image from #1.

And a comparison of the favicon with the white vs. transparent background:

favicon_comparison.png

japerry’s picture

japerry
Location KOMK
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me! FYI it can be annoying to clear cache in firefox, so try out the patch in a different browser to verify it works.

japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed

Fixed!

http://drupalcode.org/project/commons.git/commit/8af1883

Automatically closed -- issue fixed for 2 weeks with no activity.

adminaliz’s picture

adminaliz commented
Issue summary: View changes

Hey,
Just a newbie here trying to get a test site up. My ISP has supplied me with 7.34. My flavicon still has a white background even though it is transparent in my editor. Was this fix applied to 7.34 already and if not, how do I apply it? Where do I get the fix file from?

Thanks,
Bob.