attached patch enables versioncontrol API to be used in a multisite setup.

Comments

jpetso’s picture

StatusFileSize
new6.26 KB

Due to misunderstanding of PHP, I didn't quite get how to access the $xcvs variable from within that function. With you having this figured out, I wondered if we shouldn't get rid of the arguments for the bootstrapping function, and the one for retrieving the temp dir as well if we're already at it.

(The shared code should probably be moved to an xcvs-shared.php file in the same directory as the calling script, but that probably deserves a separate issue, plus I don't have time for this at the moment.)

Please test if the attached patch works for you as well.

hunmonk’s picture

StatusFileSize
new5.41 KB

actually, i think we should get rid of the global var altogether -- outside of my patch, it wasn't invoked anywhere in the versioncontrol_cvs module, the versioncontrol module, or the xcvs scripts. i think it's dead code.

most elegant fix IMO is to simply pass in the entire $xcvs array to xcvs_bootstrap()

try the attached and see how it works for you.

hunmonk’s picture

Status: Needs review » Reviewed & tested by the community

tested this thoroughly, and all of the scripts are working properly with the setup from the patch in #2

hunmonk’s picture

Project: Version Control API » Version Control API -- CVS backend
Version: 5.x-1.0-rc4 » 5.x-0.9-rc5

moving to correct issue queue

jpetso’s picture

You have commit access to all versioncontrol_* projects (since quite a while when Derek asked for those) so if you like to, you could commit this by yourself. The Version Control modules don't belong to me more than to you two, so don't be shy to commit good stuff :)

hunmonk’s picture

Status: Reviewed & tested by the community » Fixed

committed to HEAD.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.