attached patch enables versioncontrol API to be used in a multisite setup.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | vc_multisite3.patch | 5.41 KB | hunmonk |
| #1 | vc_multisite_try2.patch | 6.26 KB | jpetso |
| vc_multisite.patch | 1.25 KB | hunmonk |
attached patch enables versioncontrol API to be used in a multisite setup.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | vc_multisite3.patch | 5.41 KB | hunmonk |
| #1 | vc_multisite_try2.patch | 6.26 KB | jpetso |
| vc_multisite.patch | 1.25 KB | hunmonk |
Comments
Comment #1
jpetso commentedDue to misunderstanding of PHP, I didn't quite get how to access the $xcvs variable from within that function. With you having this figured out, I wondered if we shouldn't get rid of the arguments for the bootstrapping function, and the one for retrieving the temp dir as well if we're already at it.
(The shared code should probably be moved to an xcvs-shared.php file in the same directory as the calling script, but that probably deserves a separate issue, plus I don't have time for this at the moment.)
Please test if the attached patch works for you as well.
Comment #2
hunmonk commentedactually, i think we should get rid of the global var altogether -- outside of my patch, it wasn't invoked anywhere in the versioncontrol_cvs module, the versioncontrol module, or the xcvs scripts. i think it's dead code.
most elegant fix IMO is to simply pass in the entire $xcvs array to xcvs_bootstrap()
try the attached and see how it works for you.
Comment #3
hunmonk commentedtested this thoroughly, and all of the scripts are working properly with the setup from the patch in #2
Comment #4
hunmonk commentedmoving to correct issue queue
Comment #5
jpetso commentedYou have commit access to all versioncontrol_* projects (since quite a while when Derek asked for those) so if you like to, you could commit this by yourself. The Version Control modules don't belong to me more than to you two, so don't be shy to commit good stuff :)
Comment #6
hunmonk commentedcommitted to HEAD.
Comment #7
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.