When the label of a field gets changed, the menu is not automatically rebuilt. Therefore, e.g. the local task still shows the old label name. The enclosed patch fixes this.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | cck_menu_rebuild.patch | 526 bytes | pancho |
When the label of a field gets changed, the menu is not automatically rebuilt. Therefore, e.g. the local task still shows the old label name. The enclosed patch fixes this.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | cck_menu_rebuild.patch | 526 bytes | pancho |
Comments
Comment #1
panchomissed the patch
Comment #2
yched commentedActually, showing the field labels as secondary tabs is not really a feature ATM, but rather a buggy implementation of content.module's hook_menu(). Not sure we want to keep this. These secondary tabs might be useful to break the field settings form into subtabs.
Comment #3
panchoThat sounds like a really good idea as the field settings pages are far too complex.
However, if you rearrange the hook_menu() implementation to show fields as primary tabs and break the settings into subtabs, you still have to rebuild menus after changing the field label. So this patch is necessary anyway.
I'd like to help you polishing the cck modules and taking them to the next step. Could you try to open up the development process a bit, so there are points where I (or somebody else as well) can step in?
Comment #4
karens commentedPatches are more than welcome. Not sure what else we can do to 'open up the development process'.
And the patch is only needed if the field's name is in the menu system, which it won't be if it's no longer on a tab, so that's why this is just sitting for now. The menu_rebuild() function is a huge, massive, time-consuming resource hog, so we don't want to run it any more than necessary.
Comment #5
panchoOkay, I interpreted Yves' comment #2 in a way, that the fields might become primary tabs in a separate admin page "Configure fields" or so... Also, I made sure, menu_rebuild is only started exactly when it is really needed.
Concerning my desire to further open up the development process: I couldn't find an issue in the tracker about your plans to redesign the admin interface, to extend functionality, etc. As long as those plans are undisclosed, we can't really help you with development - and if we provide patches, it is not sure whether they are needed at all (for example this one).
My opinion is, we should keep everything as is, just fix bugs and release a CCK 6--1 ASAP. Quite a lot of people, other contrib developers as well as users are waiting for a stable release. Later we have lots of time to work on a better CCK 6--2 release.
Best regards, Pancho
Comment #6
panchoNow I found CCK 6.x and Beyond, which is very helpful to get a clue, what's going on. Could you maybe link both this one and the Port to 6.x issue on the CCK project page? Maybe with some short status information? That'd be awesome!
Comment #7
karens commentedSee http://drupal.org/node/157176, http://groups.drupal.org/node/4972, http://groups.drupal.org/node/5886, http://groups.drupal.org/node/5893, and many other threads.
We also made a presentation at DrupalCon Barcelona to at least 100 people explaining our plans, and posted them at http://drupal.org/node/177892. And there are numerous other CCK and Drupal experts who have been providing feedback and giving us patches and reviewing our ideas, including Jeff Eaton, Barry Jaspan, Moshe Weitzmann, and others.
This is by no means a 'closed' process.
We can't issue a final release until Views is updated, because the Views integration will need to be changed, and there have been changes in core as recently as yesterday that affect our code and require changes that have to be incorporated, so we're not slowing anything down by fixing whatever we find that needs fixing as we go, we can't issue a final release anyway.
We're working this week to try to get a preliminary development release issued.
The secondary tabs Yves is talking about would not have the field labels on them, but would be something like breaking the settings screen up into 'field', and 'widget' tabs, so the jury is still out on whether or not those labels will be tabs anywhere. Therefore, it is premature to commit changes until we see which way that goes.
Comment #8
karens commentedOops, we cross-posted. I can add some links to the project page. That's probably a good idea.
Comment #9
moshe weitzman commentedWell, I really like each field as subtab. In fact, I propose that these subtabs also appear under the Edit tab for the content type. That would save a click into Manage Fields tab. Presonally, I don't think the widget/field configure page is more unweildy than our other forms.
Comment #10
yched commentedWell, it's cool when you have a few fields, but on content types with 10+ fields ?
I don't think the widget/field configure page is more unweildy than our other forms
If/when we add custom validators (http://drupal.org/node/212665), it will cross a line... Ok, not done yet.
Comment #11
karens commentedI can tell you for sure that we have lots of situations where there are dozens of fields on a type. The tabs would really break down there. I agree that it's handy to have a quick link of some kind to the field, but I'm not sure the tabs are the right answer.
And on splitting up the widget/field page, some of them are already getting very complex (like the date module) and might really benefit from splitting them up or doing some kind of javascript wizardry to show and hide one section or the other.
But that is a UI issue that could wait for phase II, not needed to get an initial release out the door.
Comment #12
yched commentedI removed the fields settings pages as MENU_LOCAL_TASK for now. We can still consider options, but I'd rather not go public on the 6 branch with the subtabs on. They were never intentional in the first place, so let's not look like we're set on this.
Comment #13
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.