The theme editor works great, but how do we make the themes available for use?

It copies the files, it allows for editing, but the new/edited theme isn't available in the themes for the site/user, etc.

I had to manually copy the files into a new theme name. Then copy the extra directories for the theme to the /themes directory before they were available.

This will not be an option for members, so how do we make this automatic?

CommentFileSizeAuthor
#7 theme_editor.module.diff1.61 KBankur

Comments

walkah’s picture

did you install the theme_editor.engine in themes/engines? this should make theme_editor themes available (without needing to move).

Documentation is... forthcoming ;)

phatPhrog’s picture

Yes, the theme_editor.engine is in themes/engines. I even tried putting it in the phptemplate and xtemplate engine directories, which shuts the site down BTW and I still have no access to the edited theme.

Now, this could be a problem? The name of my theme editor engine is theme_editor_engine.engine. Is that correct or is it supposed to be theme_editor.engine?

Will try in the meantime.

phatPhrog’s picture

Sorry. Changing the name to the engine didn't work.

jlangdale’s picture

I cannot get this to work either. I can edit, but not enable that new custom theme.

blindsheep’s picture

I'm having this same problem, any help?

LuckyOne’s picture

This nice module really lacks the installation information :(
I've put theme_editor_engine.engine into themes/engines/theme_editor and the following error occured :

warning: Missing argument 1 for theme_editor_engine_templates() in /var/www/html/[skipped]/themes/engines/theme_editor/theme_editor_engine.engine on line 30.

Fatal error: Call to undefined function: system_theme_engine_inventory() in /var/www/html/[skipped]/themes/engines/theme_editor/theme_editor_engine.engine on line 32

Clean Drupal 4.6 installation, so it should be easily to reproduce. Waiting eagerly for the installation details or for the fix!

ankur’s picture

StatusFileSize
new1.61 KB

Here's a patch that just links you back to Drupal core's theme page where theme_editor edited themes will show up. It was submitted in response to an issue on civicspacelabs.org in response to a complaint that it wasn't clear how to enable a theme_editor edited theme...

Don't know if it addresses this particular issue though.

For ref: http://civicspacelabs.org/home/node/7034

-Ankur

LuckyOne’s picture

Priority: Normal » Critical

So, this module is NOT compatible with 4.6.0 because it is using 'system_theme_engine_inventory' function (does not exist in 4.6.0!). Is it possible to make it compatible?

Thanks!

LuckyOne’s picture

OK, I've managed to fix it.

Step 1: replace the line 31
old: function theme_editor_engine_templates($directory)
new: function theme_editor_engine_templates() // no parameters allowed in 4.6.0

Step 2: replace the line 32
old : $engines = system_theme_engine_inventory('themes'); // old 4.5.0 way
new: $engines = system_listing('\.engine$', 'themes/engines'); // new 4.6.0 way to get engines

PS: don't forget to put theme_editor_engine.engine into /themes/engines/theme_editor_engine/.. !
PPS: edited themes will appear in /admin/themes menu, don't forget to activate it!

Dmitry aka LuckyOne

LuckyOne’s picture

Oh, sorry, all the previously mentioned changes should be made in theme_editor_engine.engine file!

Dmitry

LuckyOne’s picture

Unfortunately, xtemplate engine has a bug, so if you are not seeing modified xtemplate themes, just open /themes/engines/xtemplate/xtemplate.engine, and fix the xtemplate_templates function:

It should look like this:
function xtemplate_templates($directory = 'themes') {
return system_listing('^xtemplate\.xtmpl$', $directory, 'filename');
}

walkah’s picture

hey guys, i've commited fixes to CVS, thanks.

Anonymous’s picture