The theme editor works great, but how do we make the themes available for use?
It copies the files, it allows for editing, but the new/edited theme isn't available in the themes for the site/user, etc.
I had to manually copy the files into a new theme name. Then copy the extra directories for the theme to the /themes directory before they were available.
This will not be an option for members, so how do we make this automatic?
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | theme_editor.module.diff | 1.61 KB | ankur |
Comments
Comment #1
walkah commenteddid you install the theme_editor.engine in themes/engines? this should make theme_editor themes available (without needing to move).
Documentation is... forthcoming ;)
Comment #2
phatPhrog commentedYes, the theme_editor.engine is in themes/engines. I even tried putting it in the phptemplate and xtemplate engine directories, which shuts the site down BTW and I still have no access to the edited theme.
Now, this could be a problem? The name of my theme editor engine is theme_editor_engine.engine. Is that correct or is it supposed to be theme_editor.engine?
Will try in the meantime.
Comment #3
phatPhrog commentedSorry. Changing the name to the engine didn't work.
Comment #4
jlangdale commentedI cannot get this to work either. I can edit, but not enable that new custom theme.
Comment #5
blindsheep commentedI'm having this same problem, any help?
Comment #6
LuckyOne commentedThis nice module really lacks the installation information :(
I've put theme_editor_engine.engine into themes/engines/theme_editor and the following error occured :
warning: Missing argument 1 for theme_editor_engine_templates() in /var/www/html/[skipped]/themes/engines/theme_editor/theme_editor_engine.engine on line 30.
Fatal error: Call to undefined function: system_theme_engine_inventory() in /var/www/html/[skipped]/themes/engines/theme_editor/theme_editor_engine.engine on line 32
Clean Drupal 4.6 installation, so it should be easily to reproduce. Waiting eagerly for the installation details or for the fix!
Comment #7
ankur commentedHere's a patch that just links you back to Drupal core's theme page where theme_editor edited themes will show up. It was submitted in response to an issue on civicspacelabs.org in response to a complaint that it wasn't clear how to enable a theme_editor edited theme...
Don't know if it addresses this particular issue though.
For ref: http://civicspacelabs.org/home/node/7034
-Ankur
Comment #8
LuckyOne commentedSo, this module is NOT compatible with 4.6.0 because it is using 'system_theme_engine_inventory' function (does not exist in 4.6.0!). Is it possible to make it compatible?
Thanks!
Comment #9
LuckyOne commentedOK, I've managed to fix it.
Step 1: replace the line 31
old: function theme_editor_engine_templates($directory)
new: function theme_editor_engine_templates() // no parameters allowed in 4.6.0
Step 2: replace the line 32
old : $engines = system_theme_engine_inventory('themes'); // old 4.5.0 way
new: $engines = system_listing('\.engine$', 'themes/engines'); // new 4.6.0 way to get engines
PS: don't forget to put theme_editor_engine.engine into /themes/engines/theme_editor_engine/.. !
PPS: edited themes will appear in /admin/themes menu, don't forget to activate it!
Dmitry aka LuckyOne
Comment #10
LuckyOne commentedOh, sorry, all the previously mentioned changes should be made in theme_editor_engine.engine file!
Dmitry
Comment #11
LuckyOne commentedUnfortunately, xtemplate engine has a bug, so if you are not seeing modified xtemplate themes, just open /themes/engines/xtemplate/xtemplate.engine, and fix the xtemplate_templates function:
It should look like this:
function xtemplate_templates($directory = 'themes') {
return system_listing('^xtemplate\.xtmpl$', $directory, 'filename');
}
Comment #12
walkah commentedhey guys, i've commited fixes to CVS, thanks.
Comment #13
(not verified) commented