When there is not enabled either 'features[] = logo' or 'features[] = favicon' in .info file for theme it shows notice message after save configuration (admin/build/themes/settings/nameoftheme).
notice: Undefined index: logo_upload in D:\xampp\htdocs\drupal6\includes\file.inc on line 494.
Part of .info file:
; features[] = logo
features[] = favicon
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | file_207736.patch | 1.03 KB | drewish |
| #4 | drupal-file-inc-undefined-index-207736-2.patch | 668 bytes | BartVB |
| #1 | drupal-file-inc-undefined-index-207736.patch | 817 bytes | anantagati |
Comments
Comment #1
anantagati commentedComment #2
BartVB commentedSeems to work as advertised.
Comment #3
drewish commentedI think it'd be better to just drop the
isset($_FILES['files'])and just go withisset($_FILES['files']['name'][$source])Comment #4
BartVB commentedisset($_FILES['files']) is indeed rather redundant :)
Behold my first Drupal patch ever:
Comment #5
BartVB commentedForgot to change the status :\ First coffee, then work :D
Comment #6
Anonymous (not verified) commentedYou need to upload the patch again, it only contains a 401 error. Also, please roll the patch to HEAD for first consideration.
Comment #7
BartVB commentedOk, fixed the attachement in #4, sorry about that! Also rerolled against HEAD.
Comment #8
cburschkaI'm afraid I don't understand the problem. garland.info includes no features[] setting at all, and it does not output any notices when saving the options. Is this something that only affects custom themes?
Edit: Ah, got it. It only happens exactly one of the lines is set, and the other is not.
Comment #9
cburschkaTested and works as advertised. RTBC, unless you want a second test.
Comment #10
Anonymous (not verified) commentedThe last submitted patch failed testing.
Comment #11
drewish commentedrerolled using CVS rather than git. restoring last status.
Comment #12
dries commentedCommitted to CVS HEAD. Thanks.