SQL error when setting standard behavior for view argument to "use empty text"

moving here on the assumption this is an i8n bug

I have similar error when using the bookimport mdoule (Drupal 5.5):

user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'LEFT JOIN i18n_node i18n ON n.nid = i18n.nid WHERE (i18n.language ='ar' OR i18n' at line 1 query: UPDATE book SET nid=441, parent=555, weight=0 LEFT JOIN i18n_node i18n ON n.nid = i18n.nid WHERE (i18n.language ='ar' OR i18n.language ='' OR i18n.language IS NULL) AND ( vid='441' ) in C:\Program Files\EasyPHP\www\drupar\includes\database.mysql.inc on line 172.

I don't have this problem on another test site with Drupal 5.3 and i18n ver 5.x-1.x-dev

Adding myself here because I have the same issue when using empty text in views.

i also got the same problem

function i18n_views_filter_handler() is missing the first parameter, $op.

The proper code is:

/**
 * Filter handler callback. Manages language selection mode
 */
function i18n_views_filter_handler($op, $filterdata, $filterinfo, &$query) {
  if ($op == 'handler' && $filterdata['field'] == 'i18n.selection' && $mode = $filterdata['value']) {
    // If this filter is used, rollback value set in pre_query and set the new one.
    i18n_selection_mode('reset');
    i18n_selection_mode($mode);
  }
}

Apologies for the lack of a proper patch. Not sure if this actually fixes the error.

The error is in i18n_db_rewrite_sql() which is rewriting an empty query for Views that had a NULL result.

There are cases where Views passes an empty query to db_rewrite_sql -- this might be considered a views bug.

Fix is to alter function i18n_bd_rewrite_sql() line 730 of i18n.module:

  if (empty($query) || $mode == 'off') return;

Here is the patch.

@catch

I think this is actually a Views bug.

This patch addresses Views passing an empty query to db_rewrite_sql.

[edit] patch is malformed -- testing [/edit]

Here's the patch -- guards against passing an empty $query to db_rewrite_sql().

Improved version of the patch.

agentrickard: your patch from #13 seems to be a good solution, thx!

This was already fixed in #247420: SQL error when using empty text as argument default and #217015: Views module sends null query when building a block, and has been committed.

Already fixed by an issue with a higher node id. Odd. But hey, a fix is a fix.