Part of #2072251: [meta] Modernize forms to use FormBase

Updated: Comment #N

Problem/Motivation

Now that #2059245: Add a FormBase class containing useful methods is in, I was looking at old forms that have empty validateForm() methods, or still use Drupal::service() or t().

Proposed resolution

Convert existing FormInterface forms to extend FormBase

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#6 drupal8-views-module-2078015-6.patch1.01 KBpushpinderchauhan
#1 drupal8.views-module.2078015-1.patch1.1 KBrosk0

Comments

rosk0’s picture

rosk0
he/him
Primary language Russian
Location Wellington
commented
StatusFileSize
new drupal8.views-module.2078015-1.patch1.1 KB
rosk0’s picture

rosk0
he/him
Primary language Russian
Location Wellington
commented
Status: Active » Needs review

For test bot.

rosk0’s picture

rosk0
he/him
Primary language Russian
Location Wellington
commented
Assigned: Unassigned » rosk0

tim.plunkett queued 1: drupal8.views-module.2078015-1.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: drupal8.views-module.2078015-1.patch, failed testing.

pushpinderchauhan’s picture

pushpinderchauhan commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new drupal8-views-module-2078015-6.patch1.01 KB

Unable to apply above patch. Please review updated patch.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Perfect!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 0cf2996 and pushed to 8.x. Thanks!

  • alexpott committed 0cf2996 on 8.x 
    Issue #2078015 by er.pushpinderrana, RoSk0 | alexanansi: Modernize...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.