In IRC, chx pointed me to http://api.drupal.org/api/function/module_load_include/HEAD

According to grep, we should probably use that in update, forum, and openid for consistency, instead of doing our own include_once() calls...

Figured a single issue in "other" was better than 3 separate issues, 1 for each module...

CommentFileSizeAuthor
#9 module_load_include-9.patch6.13 KBpancho
#7 module_load_include.patch6.12 KBpancho
#1 forum.admin_.inc_include.patch753 bytesmikey_p
#1 openid.module_include.patch3.04 KBmikey_p

Comments

mikey_p’s picture

mikey_p commented
Status: Active » Needs review
StatusFileSize
new openid.module_include.patch3.04 KB
new forum.admin_.inc_include.patch753 bytes

Here's separate patches for forum and openid

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented

+1 Looks good, we should make that move and get rid of include_once()...

birdmanx35’s picture

birdmanx35 commented

Patches install cleanly :)

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Reviewed & tested by the community

nice function.

birdmanx35’s picture

birdmanx35 commented

We also need a patch for update.module, as noted in the task... however the patches that currently exist are RTBC.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Needs work

Roll the patches into one please, include update.module and test.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Status: Needs work » Needs review
StatusFileSize
new module_load_include.patch6.12 KB

Rerolled including update.module. Ready to be tested!

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Needs work

won't apply cleanly. "patch: **** malformed patch at line 97: Index: modules/update/update.fetch.inc"

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Status: Needs review » Needs work
StatusFileSize
new module_load_include-9.patch6.13 KB

Weird... on my system it still applies cleanly, though with some fuzz now. Anyway, here's a new one.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Status: Needs work » Needs review
moshe weitzman’s picture

moshe weitzman commented
Status: Needs work » Reviewed & tested by the community

i clicked all around with various permissioned users and created user via openid. this works as advertised.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented

Thanks a lot for testing! Now let's get this fixed...

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Committed.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.