new version of autosave needs to support TinyMCE

eddie.. you da man!! works like a charm.. hopefully i'll wrap this up int he next hour and post a new ZIP

and here it is.. version 5.2 of autosave (single form per page only) with host of new features including support for TinyMCE.

- i likely should have some code to check if field is Tiny enabled.. but i left it off and non-tniy textareas still function ok.
- i should test with IE (all my testing is with FF)

sorry it's a zip and not patch..

i think outstanding issues to tie Edmund's branch and my "branch" together are:

- need generic solution for single or mutliforms per page
- need agreement on how to select which forms get autosaved; my solution only uses AS for node forms and therefore adds a node config setting to select if using autosave - possibly something like ajaxsubmit uses could be used - it adds cool admin UI that pops up on every form and asks if you want to add that one to the list of forms it knows about to enable for AS.
- anything else??

still toying with idea of adding AS period as user profile definable setting.

I was wondering what the configure_autosave was for.

So this ZIP includes version which fixes 2 bugs (almost).

- removes unsetting form_token so that form validates on sumbit
- adds nodeapi submit hook to remove AS table entry when node is submitted

bug #2 is only partially fixed with simple submit hook that i have added. There still exists issue of ajax firing off save near the same time user hits submit. Therefore submit hook will delete entry but action will already have been fired to save another copy - if it comes in after submit hook does the delete it will simply be recreated.

Likely need some sort of semaphore type lockout to prevent this properly - possibly a simple test if post[op]=submit is set when doing ajax submit would suffice? I'll test this out tomorrow.

hmm.. for some reason the ZIP didn't attach..

One more issue which i have not tested in much depth - i don't think my integration with Tiny works for IE. I think it does the save ok, just not the VIEW (pulling saved content back into Tiny fields).

there is/was also an issue with the Tiny fields not being reset when RESET is selected. This patches fixes that. Patch is on my ZIP'ed code in #6.

Still have outstanding IE issues - thats next.

an update on where i am at with this:

ADDED:

- i added this code to end of autosave.module to do the AS table clenup when a node is submitted:

/**
 * Implementation of hook_nodeapi().
 * 
 * Delete autosave table entry on successful submit of node
 *
 */
function autosave_nodeapi(&$node, $op, $a3 = NULL, $a4 = NULL) {
  if ($op == 'submit') {
      global $user;
      db_query("DELETE FROM {autosaved_forms} WHERE form_id = '%s' AND path = '%s' AND uid = %d", $node->form_id, $_GET['q'], $user->uid);
  }
}

but then realized their is an ajaxy issue that the submit could fire off around the time the ajax autosave routine fires andif it comes in after submit hook cleans the table - the entry will be replaced.

so i changed that function to this (somewhat cludgy but likely very reliable) way to ensure autosave routine doesn't add an entry if node has "just been saved:

/**
 * Menu callback; autosaves the node.
 */
function autosave_save() {
  global $user;  
  $path = $_POST['q'];
  $form_id = $_POST['form_id'];
  // Not all variables need to be serialized.
  //unset($_POST['form_token'], $_POST['q']);    
  unset($_POST['q']);  
  $serialized = serialize($_POST);
  
  // check if node has just been saved - if it has then it's because AS ajax fired off as user was submitting
  // if it had just been submitted - no need to AS now
  $path_args = explode("/", $path);
  $submitted = node_load($path_args[1]);
  
  if ((time() - $submitted->changed) > 10) {
    // Currently, each user can have only one autosave form at a particular path.
    db_query("DELETE FROM {autosaved_forms} WHERE form_id = '%s' AND path = '%s' AND uid = %d", $form_id, $path, $user->uid);
    db_query("INSERT INTO {autosaved_forms} (form_id, path, uid, timestamp, serialized) VALUES ('%s', '%s', %d, %d, '%s')",
      $form_id, $path, $user->uid, time(), $serialized);
  }
    
  exit();
}

Other issues/solutions i have finished or am working on include:

- in IE7 when i select VIEW only some fields are displayed correctly; others are blank

I originally thought this was a Tiny issue but appears to only be an IE7 issue. I have back reved a little ways and the issue is still there. I think jquery is fully functional with IE7 so that narrows the code down a bit. I'll back rev even further to see if i can narrow it down any more - hopefully shouldn't take to long to get this sorted out.

Pretty sure the issue is either in the formHash function or form.reset().

- there seems to be some issue with cursor jumping around inside a field

haven't looked at this much yet but will be next on my agenda.

- i use the checkout module (although revisions made to it) and i think it may be intefering with the autosave function - need to check that out as well.

and that's all i know of at the momeent.

figured out cause of IE7 issue: the line in jqeury.field.js:

keys = n.split(/\[(\w*)\]/);

is not supoprted by IE7

i'll see if i can find a more generic way to do this.

solution for IE7

it turns out IE7 doesn't do regex splits very well.. so using this code for the part that Edmund added to handle Drupal names with [] should be something like this (around line 303 of jquery.field.js):

else {
  // Deal with Drupal form elements with square brackets in their name (eg field_name[key]).
              var value=null;
              n = n.replace(/\[/g,','); n = n.replace(/\]/g,',');  
              keys = n.split(",");
              if (keys.length > 1) {
                for (var key in keys) {
                  if (keys[key]) {
                    if (!value) value = inHash[keys[key]];
                    else        value = value[keys[key]];
                  }
                }
              }
              jel[defaults.useArray ? "fieldArray" : "setValue"](value);

i hate JS, i hate IE... so what could be worse.. JS in IE... grrr!!!

Ok, here's my final update of this module. This fixes all the IE, Tiny, etc issues i have seen to date, including:

- Tiny fields loading properly
- cursor jumping to start of Tiny fields when autosave kicks in
- proper cleanup of autosave table on node submit.
- likely a couple other things.

enjoy.

off the top of my head i would suggest you don't "really" have jquery update. Do you know that it is necessary to copy the version of jquery.js that comes with jqueyr_update into the /misc folder? Can you view the JS file that gets loaded in your browser and tell me what version it is?

have you configured?

did you set update period (not sure what default is)?

did you enable autosave for your node type?