Checked out nb translation files from HEAD, then I am trying to make a Drupal-6--1 branch from files in HEAD

i get the error "Pre-tag check failed".

Please help! (I am using Eclipse.)

Comments

dww’s picture

dww
we/he/they
commented
Status: Active » Closed (works as designed)

try "DRUPAL-6--1". branches are case sensitive.

johnnoc’s picture

johnnoc
Primary language Norwegian Bokmål
Location Oslo
commented
Status: Closed (works as designed) » Active

sorry if I typed Drupal 6--1 here in the issue... but in CVS, I was trying to make a branch using DRUPAL-6--1 (Drupal in caps) so the problem is still there.

johnnoc’s picture

johnnoc
Primary language Norwegian Bokmål
Location Oslo
commented
Title: Cannot make a Drupal-6--1 Branch » Cannot make a DRUPAL-6--1 Branch

Rewriting the issue so it is not confusing :-) ......

Checked out nb translation files from HEAD, then I am trying to make a "DRUPAL-6--1" branch from files in HEAD

i get the error "Pre-tag check failed".

Please help! (I am using Eclipse.)

webernet’s picture

webernet commented

Did you check the files out anonymously? If so, I believe that you won't be able to check them in.

pwolanin’s picture

pwolanin commented

that would be a tag - you can only branch to DRUPAL-6

johnnoc’s picture

johnnoc
Primary language Norwegian Bokmål
Location Oslo
commented

@pwolanin:

Branching like DRUPAL-6 is outdated from Drupal 6.... it has to be DRUPAL-6--1

Starting with Drupal core 6.x, branches in the contributions CVS repository will always contain the --N part of the branch name, to remind people that each release series belongs in its own branch.. For example, the repository would prevent maintainers from creating a DRUPAL-6 branch. They would be forced to create a DRUPAL-6--1 branch for the 6.x-1.* release series for their contribution.

Ref: http://drupal.org/node/147493

@webernet:
Nope I did not checked out the files anonymously. I checked them out with my CVS account and I am the maintainer of the project.

pwolanin’s picture

pwolanin commented

yes - you're right - I was totally incorrect. Slip of the mind...

hunmonk’s picture

hunmonk commented

i would highly suggest using the command line for making branches/tags. there are a lot of people around here that can help you if you're using CLI, but not many if you're using 'my favorite IDE'...

your checkout most probably does need to happen using your approved CVS creds.

everything you need to create the branch from CLI should be found here: http://drupal.org/handbook/cvs/quickstart

robloach’s picture

robloach
he/him
commented

I get the same thing when attempting to add a branch to an install profile:

Tags not allowed in /contributions/profiles/drupalbin.

cvs tag: Pre-tag check failed
cvs [tag aborted]: correct the above errors first!

Error, CVS operation failed

hunmonk’s picture

hunmonk commented

@RobLoach: tags are not enabled for profiles yet. please open a new issue for that if you like :)

johnnoc’s picture

johnnoc
Primary language Norwegian Bokmål
Location Oslo
commented

i would highly suggest using the command line for making branches/tags

I never had a problem checking out and committing files, and creating tags and branches before, so do i have to change the method I am used to because it's not working this time?

there are a lot of people around here that can help you if you're using CLI

Am on a Windows-running PC and I don't know of any command line cvs programs for windows... if anyone could explain it to me how like I'm a 4 year old then I will gladly learn and be very thankful :-)

BUT...i guess we have to address the root of the problem.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

@JohnNoc - you don't necessarily have to change forever but at least if you try the command line way we can eliminate some pieces in the equation (eclipse, your current eclipse checkout) and help us to identify exactly which components are at fault here.

robloach’s picture

robloach
he/him
commented

@RobLoach: tags are not enabled for profiles yet. please open a new issue for that if you like :)

Sounds good.

johnnoc’s picture

johnnoc
Primary language Norwegian Bokmål
Location Oslo
commented

@greggles:

you don't necessarily have to change forever but at least if you try the command line

Quite honestly, I dont even know how and where to start. As I said, I am on a Windows PC and if anyone could guide me thru this then I will be very grateful. Well... i guess, gotta google it.

help us to identify exactly which components are at fault here.

Didn't do anything special actually. Just did what I've been doing all along. Just 2 nights ago, I made a new branch for 5.x-3.x successfully and when I am trying to make a new branch for drupal 6 then i got the error. Installed a new eclipse on another pc and checked the files out step by step according to http://drupal.org/node/37615 just to be sure. But I am still getting the same error, which is:
The server reported an error while performing the "cvs tag" command
nb: cvs tag: Pre-tag check failed
nb: cvs [tag aborted]: correct the above errors first!

So why have I successfully branched 5.x-3.x but got an error when I am branching for Drupal6? So the problem may probably lie with the new system in Drupal 6 branching (just making a guess here).

keith.smith’s picture

keith.smith commented

http://wiki.eclipse.org/index.php/CVS_FAQ#Where_can_I_get_CVS_for_UNIX_o...

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

@JohnNoc - I don't think the problem is necessarily with Eclipse or your environment either, but trying the command line will help us all debug the problem more specifically (especially if you copy past the entire set of commands).

There are many pages of documentation about cvs in our own handbooks: http://drupal.org/handbook/cvs I personally have used cvs on cygwin on Windows and the "cvs" binaries that come with WinCVS. Those are two command line options for Windows, but more and more details are in the handbook.

If you'd like, feel free to contact me in IRC or via IM (hit my contact tab and we can figure out which protocol/names will work).

johnnoc’s picture

johnnoc
Primary language Norwegian Bokmål
Location Oslo
commented

@greggles:
Thanks for the offer! I'll try to decipher things myself regarding command line cvs then i can post the set of commands here to possibly debug the problem. If I get stuck somewhere, you'll surely hear from me :-) Thanks again.

dww’s picture

dww
we/he/they
commented

@JohnNoc: just because you can go back and edit your comments later doesn't make it a good idea to keep doing so. It makes it harder to follow what you're saying. If you think of something new, please just add a new comment. Thanks.

johnnoc’s picture

johnnoc
Primary language Norwegian Bokmål
Location Oslo
commented

@dww:When i edited a comment above its not because there's something new. The edit for example was:
Original : Reply for pwolanin's comment
Edited to: @pwolanin
just to reflect the norm we're using in adressing a msg to someone.

Anyways....
I successfully branched to DRUPAL-6--1 with WinCVS. There are no commands to paste here because there were no abnormal messages WinCVS reported. But nevertheless, it is still a mystery why I could not branch to 6.x by using eclipse and i could branch to 5.x-3-x.

dww’s picture

dww
we/he/they
commented
Category: bug » support
Status: Active » Fixed

@JohnNoc: well, it's hard to know what you edited unless you say so, which just proves my point: "It makes it harder to follow what you're saying"... ;)

Now that you mention it, I think eclipse has some brain-dead logic where it always tries to add something like a "DRUPAL-6--1-root" tag automatically, without your knowledge or consent, whenever you try to create a "DRUPAL-6--1" branch. Our CVS repository prevents these extra tags, since they don't follow our conventions and would needlessly clutter the repository.

This is why I generally hate CVS GUIs. They think they're so smart.

Anyway, sounds like this is resolved... feel free to reopen it if you think there's something else that needs to be done.

Cheers,
-Derek

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

allisterbeharry’s picture

allisterbeharry commented

Eclipse 3.3 makes a tag called Root_YOUR-BRANCH by default everytime you make a branch to YOUR_BRANCH. You can change this to a Drupal compatible tag in the Branch.. dialog by editing the 2nd textbox labelled version "Version Name" According to Eclipse this tag is used to merge changes from the branch back to the source branch...not a CVS expert so don't know how this would work but this is probably the problem in creating a DRUPAL-6--1 branch in Eclipse. You can always tell what's going on with Eclipse's CVS client by looking at the Eclipse console output:

cvs tag "/Views Datasource/DRUPAL-6--1-0" "/Views Datasource"
cvs tag: Tagging .
T README.txt
T views-view-json.tpl.php
T views-view-row-unformatted.tpl.php
T views_json.info
T views_json.module
T views_json.views.inc
ok (took 0:00.674)
***

***
cvs tag -b "/Views Datasource/DRUPAL-6--1" "/Views Datasource"
cvs tag: Tagging .
T README.txt
T views-view-json.tpl.php
T views-view-row-unformatted.tpl.php
T views_json.info
T views_json.module
T views_json.views.inc
ok (took 0:00.771)

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented

FWIW, in my case Eclipse is not adding the -b to the command, even though I'm clearly selecting Branch on the team menu. Looks like a bug in Eudora (3.2) ... =(

ipwa’s picture

ipwa commented

This solved my problem, thanks so much! Just make a tag DRUPAL-6--1-0 instead of Root_DRUPAL-6--1, when you're branching and everything works well.

adaddinsane’s picture

adaddinsane
him/he/his
commented

I confirm this as the solution (just been beating my head against the wall about it for a day - eventually found this posting).

When branching using Eclipse CVS - put the correct branch name in the top field, such as DRUPAL-6--1, which then gives you Root_DRUPAL-6--1 in the bottom field. Delete "Root_" from the front and add -0 to the end.

It will then branch correctly.

(EDIT for style and content.)

wiifm’s picture

wiifm
Primary language English
Location Wellington, NZ
commented

@adaddinsane - thankyou, lifesaver

domidc’s picture

domidc commented

I confirm #25 as a working solution.

domidc’s picture

domidc commented

There is however one drawback to use #25, when you want to make your 6.1.0 release it says the tags is allready in use. What I did was create a 6.1.1 release as the first non dev release of the branch.

Component: CVS » Other