menu title custom translation fn not used [#207908]

Comment	File	Size	Author
#12	menu_item_localize_unify_wdoc.patch	5.51 KB	jvandyk
#9	menu_item_localize_unify.patch	4.46 KB	chx
#6	menu_item_localize_unify.patch	4.11 KB	chx
#5	menu_item_localize_unify.patch	4.1 KB	chx
#1	menu_item_localize_unify.patch	4.03 KB	chx

Comment #1

chx commented 9 January 2008 at 06:36

Status:

Active

» Needs review

Status	File	Size
new	menu_item_localize_unify.patch	4.03 KB

Also there is code duplication, oh horror! We can certainly do better. I moved all the relevant code to menu_item_localize. Not much change needed there, the patch looks bigger because I needed to indent most of that function.

Log in or register to post comments

Comment #2

becw commented 9 January 2008 at 06:46

Status:

Needs review

» Reviewed & tested by the community

Log in or register to post comments

Comment #3

bdragon commented 9 January 2008 at 06:57

Status:

Reviewed & tested by the community

» Needs review

(setting to cnr while becw writes up how she tested..)

Log in or register to post comments

Comment #4

becw commented 9 January 2008 at 07:14

I'm getting two errors on the admin/build/menu-customize/navigation page:
* notice: Undefined index: map in menu.inc on line 1460.
* notice: Uninitialized string offset: 0 in menu.module on line 177.

the menu item titles are showing up correctly, though (run through the custom translation callback).

Log in or register to post comments

Comment #5

chx commented 9 January 2008 at 07:18

Status	File	Size
new	menu_item_localize_unify.patch	4.1 KB

Forgot to move a piece of code.

Log in or register to post comments

Comment #6

chx commented 9 January 2008 at 07:31

Status	File	Size
new	menu_item_localize_unify.patch	4.11 KB

The $item['map'] = $map; needs to be on its own.

Log in or register to post comments

Comment #7

becw commented 9 January 2008 at 14:16

Status:

Needs review

» Reviewed & tested by the community

tested w/ 3 menu items (one each specifying title and title callback, title and title arguments, and title arguments and title callback). worked in all cases.

Log in or register to post comments

Comment #8

becw commented 9 January 2008 at 15:12

Status:

Reviewed & tested by the community

» Needs review

the title of the breadcrumb link seems to be run through the custom translation function *twice*.

Log in or register to post comments

Comment #9

chx commented 10 January 2008 at 16:39

Status	File	Size
new	menu_item_localize_unify.patch	4.46 KB

Well, then the second call is not necessary... it's broken anyways because if a customized item is in the active trail which had a custom menu callback that would fire and overwrite the user set title.