There already exists a $custom_theme variable in Drupal - suggest using something else!

gpk - January 9, 2008 - 11:24
Project:Block Theme
Version:5.x-1.1
Component:Documentation
Category:bug report
Priority:minor
Assigned:Unassigned
Status:active
Description

Just a minor suggestion - global $custom_theme is used to override the main $theme variable. Obviously your $custom_theme as per the code on the main project page http://drupal.org/project/blocktheme is different, but this could cause confusion.

Also I find the function name blocktheme_get_theme() in the context of [yourtheme]_block($block) confusing since the word "theme" is used to mean both the site theme and a "type" or "class" of block (for themeing purposes). (Actually could use phptemplate_block($block) anyway here, but the use of "theme" in blocktheme_get_theme is still a bit confusing to a poor old soul like me!)

Hope this helps!

#1

JacobSingh - February 14, 2008 - 08:59
Priority:normal» minor

Hi gpk,

Good feedback and I totally agree, if you have time can you submit a patch with these changes? Sorry, but I'm too busy to deal with minor issues right now like syntax, etc.

Otherwise, I'll get to this in a few weeks when things settle down.

Best,
J

#2

gpk - February 14, 2008 - 09:02

Thanks, looks like it'll be a race to see who doesn't get round to this then ... :-P
Best,
gpk

#3

JacobSingh - June 25, 2008 - 11:28

Yeah, dropping for now, as Gertjan is taking over the 6.x version. Let's see if he/she is going to deal with it :)

 
 

Drupal is a registered trademark of Dries Buytaert.