Just a minor suggestion - global $custom_theme is used to override the main $theme variable. Obviously your $custom_theme as per the code on the main project page http://drupal.org/project/blocktheme is different, but this could cause confusion.

Also I find the function name blocktheme_get_theme() in the context of [yourtheme]_block($block) confusing since the word "theme" is used to mean both the site theme and a "type" or "class" of block (for themeing purposes). (Actually could use phptemplate_block($block) anyway here, but the use of "theme" in blocktheme_get_theme is still a bit confusing to a poor old soul like me!)

Hope this helps!

Comments

JacobSingh’s picture

Priority: Normal » Minor

Hi gpk,

Good feedback and I totally agree, if you have time can you submit a patch with these changes? Sorry, but I'm too busy to deal with minor issues right now like syntax, etc.

Otherwise, I'll get to this in a few weeks when things settle down.

Best,
J

gpk’s picture

Thanks, looks like it'll be a race to see who doesn't get round to this then ... :-P
Best,
gpk

JacobSingh’s picture

Yeah, dropping for now, as Gertjan is taking over the 6.x version. Let's see if he/she is going to deal with it :)

amateescu’s picture

Status: Active » Fixed

This is fixed in 6.x-1.1.

Blocktheme 5.x is not maintained anymore. Please upgrade to the latest 6.x release if possible.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.