Hello,
do you want add PostgreSQL database for Drigg ? Thank you very much.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | drigg.install-208050.patch | 1.22 KB | jaydub |
Hello,
do you want add PostgreSQL database for Drigg ? Thank you very much.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | drigg.install-208050.patch | 1.22 KB | jaydub |
Comments
Comment #1
Libor Fikr commentedComment #2
mercmobily commentedHi,
I would love to. However, I've never ever used PostgreSQL.
So, I will need:
* A patch for the .install file
* Somebody able to test it carefully
Any volunteers?
Merc.
Comment #3
jaydub commentedThere are a few queries in the current module that would need to be updated to work in PostgreSQL but the one major area that might make PostgreSQL support difficult is the use of MySQL's FULLTEXT feature.
The drigg.install file adds a FULLTEXT index on the node_revisions table and searches the FULLTEXT index in the drigg_get_related_links_uids function.
I can help start the work by adding the table and index creation code as a patch for drigg.install but the FULLTEXT question and the couple of queries to with MySQL specific commands will have to wait until I get back from my holiday on the beach :)
Comment #4
mercmobily commentedHi,
Any news on this one?
I am about to release the next version of Drigg. Are you able to send the the patches once I've released it?
Bye!
Merc.
Comment #5
jaydub commentedjust got back from holiday. After you release a new version I'll take a look and update my patch.
Comment #6
mercmobily commentedHi,
OK thanks!
Merc.
Comment #7
mercmobily commentedHi,
I hope you enjoyed the beach!
I've released the module. It's all ready to roll :-D
Merc.
Comment #8
mercmobily commentedComment #9
mercmobily commentedHi,
Is anybody at all interested in this? And more importantly, is anybody able to send us a patch?
If not, I will mark it as "Won't fix". It's been in the queue for ages, and no progress.
Merc.
Comment #10
mercmobily commentedComment #11
jaydub commentedOk it's been awhile since I've seen the code...for this to be usable in PostgreSQL
you have to redo a whole lot of SQL...
You have UNIX_TIMESTAMP(CURRENT_TIMESTAMP()) and other variations
of UNIX_TIMESTAMP littered throughout the codebase. This is a MySQL specific
function. Whenever you have UNIX_TIMESTAMP(CURRENT_TIMESTAMP()) why are
not just passing time() from PHP to a query placeholder?
Pligg import has several of these types of queries:
db_query("ALTER TABLE {term_data} AUTO_INCREMENT=%d",$max);
I'm not sure what is supposed to do as normally AUTO_INCREMENT is
a column property and not something performed on a table ?
The other major issue which maybe can't be resolved as easy as the
others is the use of the MySQL FULLTEXT function on the node_revisions
table. The FULLTEXT is used in drigg_rl.module it appears. I don't know
enough about fulltext to know where to go from there.
A small side note, have you ever run Coder module against your modules?
coding standards could use a looksee in your code.
Comment #12
mercmobily commentedHi,
The code needing love for indentation etc. is a separate issue. You helped in the past with other modules... I will use the coder module!
For Postgresql.. it looks like a major job. However, if you could send us a patch to make sure that the timestamp is taken for PHP, that would be a good first step!
For the pligg importer... that's how you set the auto increment in MySql. I know it looks weird, but that's how it's done.
I am not too fussed about Postgres support, but it would be nice...
Bye,
Merc.
Comment #13
mercmobily commentedHi,
Three and a half months, no real patch, no real follow up, no real hope to get this done, marking as won't fix.
If somebody has a working, tested patch, please reopen and post patch here.
I won't.
Merc.
Comment #14
mercmobily commentedHi,
Three months, no patch. I don't know postgres, and it doesn't look like a solution is even in sight.
Until somebody submits a tsted, working patch which makes Drigg work 100% with Postgres, this is a "postponed".
Merc.
Comment #15
mercmobily commentedHi,
I don't think this is gonna happen.
I can't fix this. So, it's a "won't fix".
Merc,