remove hook_simpletest, use tests directory in module dir.

dopry - January 9, 2008 - 21:42
Project:SimpleTest
Version:5.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed
Description

Currently if you want to distribute tests with your module you have to write addition code in your module, which is completely superfluous if you are not running tests. This patch removes hook_simpletest completely and looks in the /tests/ folder of each module directory.

I think it is a nice simplification simply because it will remove 5 repeated lines of code in every module that wants to implement simpletests. It will also create a standard location where people know to look for/place tests.

AttachmentSizeStatusTest resultOperations
nohook_simpletest.patch1.83 KBIgnoredNoneNone

#1

webchick - January 10, 2008 - 04:16
Status:active» reviewed & tested by the community

Oh, +1 for this! I've always thought this was rather silly.

Tested the patch and it works. There were a couple minor spacing errors that I fixed. Please don't credit me for the patch.

AttachmentSizeStatusTest resultOperations
nohook_simpletest.patch1.82 KBIgnoredNoneNone

#2

moshe weitzman - January 10, 2008 - 13:25

yes, make sense

#3

Rok Žlender - January 11, 2008 - 17:03
Status:reviewed & tested by the community» fixed

Committed to both HEAD and D5 versions. Thanks dopry and webchick.

#4

webchick - January 20, 2008 - 19:02
Status:fixed» patch (to be ported)

#5

webchick - January 20, 2008 - 19:02
Status:patch (to be ported)» fixed

Er. Sorry, this one was already ported. :)

#6

Anonymous (not verified) - February 3, 2008 - 19:11
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.