When a call is successfully excuted via xmlrpc a notice is generated

Trying to get property of non-object in C:\broker6\includes\xmlrpcs.inc on line 70.

Patch to remove notice

CommentFileSizeAuthor
#4 208195-xmlrpc-notice.patch647 bytesboombatower
#1 xmlrpcerrjv.patch696 bytesjvandyk
xmlrpcs.inc_.patch602 bytesmarcingy

Comments

jvandyk’s picture

jvandyk commented
StatusFileSize
new xmlrpcerrjv.patch696 bytes

We should check if it's an object. If it's not an object, it's not an xmlrpc error object and we shouldn't be looking for a property on it.

boombatower’s picture

boombatower commented
Status: Needs review » Reviewed & tested by the community

This is extremely annoying when working with XML-RPC as I do with PIFR/PIFT. Every time any traffic goes through I get those messages in my watchdog log. I submitted the patch that fixed this in D7, lets get this in.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Reviewed & tested by the community » Needs review

By the way, you can (and should) roll all that into !empty($result->is_error).

boombatower’s picture

boombatower commented
Assigned: Unassigned » boombatower
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 208195-xmlrpc-notice.patch647 bytes

Seems to work locally.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Reviewed & tested by the community » Needs review

Almost there... empty($result->is_error) should also cover the condition is_object($result). :)

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Reviewed & tested by the community

So crazy result, it will only return true if $result = array('is_error' => TRUE);. So I guess checking is_object is fine too.

boombatower’s picture

boombatower commented

ping.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed to Drupal 6.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented

Issue for D7: #677750: XMLRPC server call creates unnecessary watchdog entries