remove xmlrpcs.inc notice
marcingy - January 10, 2008 - 00:21
| Project: | Drupal |
| Version: | 6.x-dev |
| Component: | base system |
| Category: | bug report |
| Priority: | normal |
| Assigned: | boombatower |
| Status: | closed |
Description
When a call is successfully excuted via xmlrpc a notice is generated
Trying to get property of non-object in C:\broker6\includes\xmlrpcs.inc on line 70.
Patch to remove notice
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| xmlrpcs.inc_.patch | 602 bytes | Ignored | None | None |
#1
We should check if it's an object. If it's not an object, it's not an xmlrpc error object and we shouldn't be looking for a property on it.
#2
This is extremely annoying when working with XML-RPC as I do with PIFR/PIFT. Every time any traffic goes through I get those messages in my watchdog log. I submitted the patch that fixed this in D7, lets get this in.
#3
By the way, you can (and should) roll all that into
!empty($result->is_error).#4
Seems to work locally.
#5
Almost there... empty($result->is_error) should also cover the condition is_object($result). :)
#6
So crazy result, it will only return true if
$result = array('is_error' => TRUE);. So I guess checking is_object is fine too.#7
ping.
#8
Thanks, committed to Drupal 6.
#9
Automatically closed -- issue fixed for 2 weeks with no activity.