XML-RPC error handling broken

This is by design:

/**
 * Returns the last XML-RPC client error number
 */
function xmlrpc_errno() {

The proper, reliable way to use multiple XML-RPC calls is to wrap them in a try/catch block. For example:

<?php
function XmlRpcException()
{
    if(xmlrpc_errno()) {
        throw new Exception('An error has occured');
    }
}

try {
  xmlrpc('foo', ...); // fails
  XmlRpcException(); //throws exception
  xmlrpc('bar', ...); //never gets here
  XmlRpcException();
}
catch(Exception $e)
{
  echo 'Caught exception';
}
?>

I think that however the proper way to handle this would be to modify xmlrpc so that it will throw an exception on failure, rather than simply setting a static variable. Unsetting the static variable could be problematic, as there may be contributions which are using xmlrpc_errno() in a way which checks to see if anything in a series of XML-RPC calls has failed.

Regardless of who or what should be responsible for keeping track of the success/failure of xmlrpc() calls, as long as we're not modifying xml-rpc core then we should be okay.

+1 on the patch, applied against HEAD and works properly.

Agreed, duplicate with duplicate patch.

I take that back, the other patch resets the error code every time a call is made, which is not desired functionality.

Automatically closed -- issue fixed for two weeks with no activity.