When a user is viewing her own guestbook, the form to add a new guestbook entry should not be displayed.
Furthermore, when leaving a comment on a guestbook entry, only the relevant guestbook entry should be displayed.
Attached patch fixes that.
However, it's impossible for me to provide a proper patch, because all files of guestbook contain Windows carriage-returns (not in UNIX-format).
I've tried to create a patch with Windows line-endings, but after (already too much) unnecessary trials, I'm leaving this up to you.
Is this module seeking a new maintainer? There's an issue about wrong file formats in the queue since October 2006. Let me know, if I can help out.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | guestbook-DRUPAL-5--2.comment-one.patch | 1.77 KB | sun |
| guestbook-DRUPAL-5.patch | 63.98 KB | sun |
Comments
Comment #1
nicholasthompsonOctober 2007 actually ;-)
I'm not sure I agree with your point about not showing a guestbook form on your own guestbook. What if someone posts something on your guestbook and you want to reply?
I IMAGINE that a lot of people use the Guestbook module in a similar way to Facebook's "wall" feature.
Btw: What are you programming in? Nearly all half-decent IDE's and editors contain a setting for line endings. UltraEdit has the DOS/Unix filetype handling settings, Zend Studio has a newline setting in it and BBEdit for OSX also has a little drop down at the bottom of the window to control line endings.
Comment #2
sunre: hiding comment form
Guestbook provides two comments forms -- one to add a new guestbook entry (which should only be displayed on guestbooks) and another one to leave a comment on a guestbook entry (which should be kept, of course). The first one should be removed, because you can not add a guestbook entry in your own guestbook anyway.
re: I'm developing on Windows, using TortoiseCVS. It's definitely not my editor. I've tested various settings TortoiseCVS, but no way... either way, CRLF sucks.
Comment #3
sunNicholas: Do you agree with my clarification in #2 ? If so, I'd like to commit that patch.
Comment #4
nicholasthompsonI do see your point...
Personally I see Guestbook as a very useful tool to emulate the Wall feature on Facebook. Removing the ability to quickly post to your own book feels like a step in the wrong direction (in my opinion).
I would certainly be up for the idea being an OPTION as I can also see situations where you wouldn't want a comment form on your own guestbook.
Comment #5
sunCommitted attached patch for 2.x.
Does not remove guestbook post form from own guestbook - however, from my testing, I'm still unable to add a guestbook post to my own guestbook anyway... (which is different issue)
Comment #6
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.