Settings at /admin/build/themes/settings/eldir doesn't affect logo.

Please Help!

CommentFileSizeAuthor
#2 eldir-logo.patch1.44 KBchertzog
#2 logo.png4.16 KBchertzog

Comments

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented
Category: feature » bug

I can confirm this. In the short-term, perhaps consider creating a sub-theme

chertzog’s picture

chertzog
he/him
Primary language English
Location Harrisburg, PA, USA
commented
Version: 6.x-2.0-rc2 » 7.x-3.x-dev
Status: Active » Needs review
StatusFileSize
new logo.png4.16 KB
new eldir-logo.patch1.44 KB

Here is a patch that changes the way the logo is handled, and allows switching it via the settings form. Also included is an image containing just the logo.

anarcat’s picture

anarcat commented

it would be nice to keep the sprite by default, is that possible?

it doesn't look like the patch sets a default value for the logo... is there something missing here?

chertzog’s picture

chertzog
he/him
Primary language English
Location Harrisburg, PA, USA
commented

As far as im aware, if the theme includes a logo.png file, it will be used as the logo for the default theme. This is why we cant use the sprite for it. it needs to be a separate file.

anarcat’s picture

anarcat commented

got it, it's good then.

theohawse’s picture

theohawse commented

can this be committed?

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented
Version: 7.x-3.x-dev » 6.x-2.x-dev
Status: Needs review » Fixed

Fixed in 06ef4db.

theohawse’s picture

theohawse commented
Status: Fixed » Closed (fixed)

Awesome thanks!