Closed (fixed)
Project:
Request Invitation
Version:
5.x-1.1
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
11 Jan 2008 at 03:09 UTC
Updated:
25 Dec 2009 at 16:47 UTC
Jump to comment: Most recent file
Comments
Comment #1
buddhika commentedHi dafeder,
To change the description of the block follow this.
At the top of "requestinvitation.module" script there are two lines like this.
//Give a description about your site here
$description = "You can give a brief description of your site or what you intended to do through this module here." ;
Replace "You can give a brief description of your site or what you intended to do through this module here." with your welcome blurb.
To edit the theme you will have to use your own theme as only a general theme is given with the module.
Cheers,
Laknath
Comment #2
Christefano-oldaccount commentedI don't like having to edit the module and would prefer a setting. Until that happens, the strings should at least be translatable with either the Locale module or the method described at #131061. This patch does that.
Comment #3
buddhika commentedHi christefano,
Thanks for the patch. It's committed.
Comment #4
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #5
csc4 commentedHow is it fixed? It doesn't seem to be in the downloadable versions of the files??
If it is truly a description of the site - could it perhaps default to the site slogan or mission if nothing else is defined?
Comment #6
buddhika commentedOops...Forgot to make a new release :-) Thanks for reminding me.
Added for a new release and should be downloadable within few hours.
Comment #7
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #8
gregglesJust for the record, this was committed with the message "Security: ..." which implies that it fixes a security bug. In fact, it fixes no security bugs.
@buddhika - if you have questions about writing secure code please read the handbook http://drupal.org/writing-secure-code if there are areas which you are still unsure about please ask the security team.
Comment #9
buddhika commentedNow description text can be modified from within the module in 5.x-1.1 release.
Thanks for pointing this out.
Comment #10
summit commentedGreat! Thanks for this great module! greetings, Martijn
Comment #11
gregglesYes, but, you are now using t() inappropriately and have introduced an xss security hole. User entered data should not be simply passed through to end users. In this case, I suggest that you get rid of the t() function in t(getDescription()); and instead use filter_xss_admin(get_description());
Please do carefully read the writing secure code section of the handbook http://drupal.org/writing-secure-code
Comment #12
buddhika commentedThanks @greggles for noting the security hole. Fixed.