Voting does not work if Devel module is activated

in additon it shows
"
warning: Missing argument 1 for drigg_help() in D:\Inetpub\websites\drupal5\sites\all\modules\voting\drigg\drigg.module on line 8.
"

after click the voting button, it shows "karma error: parseerror"

i am not sure if it caused by conflict with other module. i will go through the code and try to find out the problem this weekend. :)

hi Merc,

thanks for your quick apply.

after comment out the "drigg_db_rewrite_sql“ function, error msg shows "user warning: Query was empty query:"

so seems the system send some empty query somewhere.

Hi Merc,

I am not using drupal 5.5 but 5.2 instead.

Drigg must run on 5.5?

Instead of using ur default theme, i followed ur online install instruction and copied those functions to my current theme.

after doing so, the db error gone.

but the after voting, it still shows "Karma Error: parsererror".

I checked the code, it's from jquery.

if ( status == "success" ) {
					// Watch for, and catch, XML document parse errors
					try {
						// process the data (runs the xml through httpData regardless of callback)
						data = jQuery.httpData( xml, s.dataType );
					} catch(e) {
						status = "parsererror";
					}
				}

actually, the data updating has been done, after refresh the page, the correct voting result will be displayed. the only problem is Ajax failed to update result after voting due to the "parsererror".

sorry, i only tested it on my local server.

i have the latest jquery.

the problem is there is some conflict with devel module.

the value send back was

{"karma_aggregate":1}  and devel information, "the execution time", "memory" 

i believe it should be simply "{"karma_aggregate":1}"

Hi Merc,

I see the problem.

To fix it and the right way to return json is

in extra_voting_forms.module

1. in "extra_voting_forms_return" function, dont print the output and exit, but return the string value to "extra_voting_forms_handle".

2. in "extra_voting_forms_handle" function, dont print the output either, but do

exit(extra_voting_forms_return(@params).

in this way, the devel module will not append extra information to your json output.

I have tested it on my server, and it works well.

Cheers!

Welcome further discussion.

Hi Merc,

Here is the updated extra_voting_forms_return and extra_voting_forms_handle function.

By doing so, you can get the clean json without devel info appended.

i hope i made myself clear. :)

function extra_voting_forms_return($form_type,$object,$error,$current_karma){

  if($form_type == 'ajax'){

    // Adjust the string for Ajax...
    if($current_karma===''){
      $current_karma='"Undefined"';
    }

    // Return the right thing to the javascript
    if($error != ''){
      
      $output = "{\"karma_aggregate\":$current_karma, \"error\":\"$error\"}";
      //print "{\"karma_aggregate\":$current_karma, \"error\":\"$error\"}";
      #drupal_set_message($error);
    } else {
      
      $output = "{\"karma_aggregate\":$current_karma}";
      //print "{\"karma_aggregate\":$current_karma}";

    }
    //module_invoke_all('exit');
    return $output; 

  } else { 

    if($error != ''){
      drupal_set_message($error,'error');
    } else {
      drupal_set_message(t('Thank you for voting!'));
    }
    drupal_goto(referer_uri());
  }

}

function extra_voting_forms_handle(){

  global $_REQUEST, $user;

  // The form has been posted...
  if ($_REQUEST['form_type']) { 

    // Set the incoming variables
    $oid        = $_REQUEST['oid'];
    $otype      = $_REQUEST['otype'];
    $karma_vote = $_REQUEST['karma_vote'];
    $form_type  = $_REQUEST['form_type'];


    // If otype isn't 'c' or 'n', return to the home page
    if($otype != 'c' && $otype != 'n'){
      exit(extra_voting_forms_return($form_type,$o,t('Error in the form'),''));
    }

    // Create the object, and load it
    $o= new stdClass();
    $o->sk_id = $oid;
    $o->sk_type = $otype;
    $o=extra_voting_forms_load_object($o);
    if(!$o){
      exit(extra_voting_forms_return($form_type,$o,t('Error loading the object!'),''));
    }

    // Check that $form_type is sane. extra_voting_forms_return does NOT
    // check it as a parameter
    if($form_type != 'ajax' && $form_type != 'form'){
      drupal_set_message(t('Error in the parameters!'),'error');
      drupal_goto('node/'.$o->nid);
    }    



    // It's a direct form, and the user doesn't
    // have voting rights!
    if($form_type != 'ajax' && $user->uid == 0){
      drupal_goto( extra_voting_forms_anonymous_url(), "destination=".extra_voting_forms_destination($o) );
    }

    // Give the vote and return. $give_vote_return will return the error
    // message (if there was one) or '' if all went OK. This is exactly what
    // extra_voting_forms_return expects, which is handy...
    list($give_vote_return,$k)=extra_voting_forms_give_vote($o,$karma_vote);
    
    if(! variable_get('extra_voting_forms_display_karma_for_'.$o->sk_type, 0) ){
      $k='';
    }
    drupal_set_header("Content-Type: text/json");
    exit(extra_voting_forms_return($form_type,$o,$give_vote_return,$k));

  }

}

sorry, mistakenly reset the priority.

the above code is just an example, i have not studied your code thoroughly. I just want to show you my way to send clean json without devel info.

the database error has gone after i changed back to my previous theme, not sure abt what's wrong with your theme functions.

That's great!

Truly wish you all the best and great success with your drigg project.