safari version 2.0.4 crashes. firefox v2 does not crash.

this occurred on upgrade from rc1 to rc2. then deleted all drupal tables and started from scratch with no modules.
still safari crashes.

php 5.2.2,apache 1.3.33, mysql 5.0.41 intel

CommentFileSizeAuthor
#17 tableheader_saf_choke1b.patch856 bytesdvessel
#15 tableheader_saf_choke.patch859 bytesdvessel

Comments

dsp1’s picture

dsp1 commented
Priority: Normal » Critical

i checked my log and it showed javascript. so I disabled javascript in safari and no crash.

i also tested other areas. with javascript turned on , it crashes on many admin pages including blocks, user>access rules, etc.

stborchert’s picture

stborchert
he/him
Primary language German
commented

i checked my log and it showed javascript

Could you please post the messages written to your log file. Otherwise it could be very difficult to reproduce.

thanks,

Stefan

dsp1’s picture

dsp1 commented

here is the log. i will spare you the repeated threads, but threads 2 and 3 repeat 250 times each with the final number 508. unfortunately it does not show which script is the last to run. only six js files were changed from rc1 to rc2 in misc folder. i would venture to guess it is one of the six.

Version: 2.0.4 (419.3)
Build Version: 31
Project Name: WebBrowser
Source Version: 4190300

PID: 711
Thread: 0

Exception: EXC_BAD_ACCESS (0x0001)
Codes: KERN_INVALID_ADDRESS (0x0001) at 0xbf7ffe0c

Thread 0 Crashed:
0 com.apple.JavaScriptCore 0x952f64fb match + 12
1 com.apple.JavaScriptCore 0x952f73d5 match + 3814
2 com.apple.JavaScriptCore 0x952f667d match + 398
3 com.apple.JavaScriptCore 0x952f73d5 match + 3814

scor’s picture

scor commented

not able to reproduce this on safari 3.0.4 (523.12). is there any way to downgrade to safari 2 on mac OS X 10.4.11 to try to reproduce this?

stborchert’s picture

stborchert
he/him
Primary language German
commented

is there any way to downgrade to safari 2 on mac OS X 10.4.11 to try to reproduce this?

I couldn't check it here but you should be able to uninstall safari 3 (uninstaller is shipped within dmg).

btw:
http://lists.apple.com/archives/client-management/2008/Jan/msg00023.html

catch’s picture

catch
he/him
Primary language English
commented

dps1, do you have any browser plugins installed?

dvessel’s picture

dvessel commented

Haven't tried yet.. http://michelf.com/projects/multi-safari/

There are some issues with Leopard so I'm waiting until they iron that out even though there's a workaround.

scor’s picture

scor commented
Version: 6.0-rc2 » 6.x-dev
Component: base system » javascript

thanks dvessel for the link. I can definitely reproduce this on safari 2.0.4 (419.3), and the previous versions of safari 2 are also unstable, especially when tableheader and tabledrag are used together (blocks).
It seems that the jquery clone() of tableheader.js is the problem: no crash when clone(true) is removed. No crash either when using the previous version of tableheader.js (1.9).

chx’s picture

chx commented

Do we need to support Safari 2?

scor’s picture

scor commented

I was actually wondering is safari 2 was still used by many people, given that safari 3 is now shipped with mac os since Mac OS X Update 10.4.11
We still need to disable the tableheaders for safari 2 though.

mfer’s picture

mfer commented

I think we still need to support safari 2. There are a lot of people who still use it. Not as many as IE 6. But, we don't want to be a platform that isn't supporting it.

dvessel’s picture

dvessel commented

We shouldn't bend over backwards to support it. It was always a buggy browser and as scor mentions, Safari 3 is an automatic download with 10.4. Since I caused the problem, I'll try to find a fix. If a workaround is not easy, I think we should treat it like IE6.. Just disable it.

mfer’s picture

mfer commented

That's support enough for me :-)

scoutbaker’s picture

scoutbaker commented

+1 for treating Safari 2 like IE6 if there isn't an easy workaround. Graceful degradation is good.

dvessel’s picture

dvessel commented
Status: Active » Needs review
StatusFileSize
new tableheader_saf_choke.patch859 bytes

This does it for me. Very simple fix. It wasn't just the clone. It was the long chain of commands it didn't like.

m3avrck’s picture

m3avrck commented
Status: Needs review » Needs work

Since headerClone is already a jQuery object, calling $(headerClone) is unecessary (and a tad slower).

headerClone.addClass('sticky-header').css({

Should work better.

dvessel’s picture

dvessel commented
Status: Needs work » Needs review
StatusFileSize
new tableheader_saf_choke1b.patch856 bytes

Great, thanks for the advise.

dvessel’s picture

dvessel commented
Status: Needs review » Needs work

Changing status due to this issue. That'll be fixed first since it's the same area of code that needs to be changed.

dvessel’s picture

dvessel commented
Status: Needs work » Closed (duplicate)

The fix for the default radio select patch seems to fix the crashes also. Please test it out.

http://drupal.org/node/208179

dsp1’s picture

dsp1 commented

applied the patch from the other node and no crashes. thanks dvessel for the fast fix.