In action_send_email(), $node is not required and should have default value set

Benjamin Melançon - January 11, 2008 - 12:20
Project:Actions
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Benjamin Melançon
Status:needs review
Description

Patch attached to add $node = NULL, also rolls in another bugfix with a couple style changes from Anonymous users, %username, and action_send_email().

Hoping an omnibus patch makes things a little easier for the maintainer!

Question to module maintainer: What is the relationship to the 5.x code and the actions module now in 6 core?

I am assuming we should be making an effort to port bug fixes from one to the other as they're found, but there isn't an actions.module for the Drupal project issue queue so I don't know where to look.

AttachmentSize
actions_inc_omnibus_bugfix.patch766 bytes

#1

Benjamin Melançon - January 11, 2008 - 12:27

How to apply a patch, MacOSX and Linux this should just work:

patch < actions_inc_omnibus_bugfix.patch

I'll keep posting these reminders at least until I can remember this simple code from one time to the next!

benjamin, Agaric Design Collective

 
 

Drupal is a registered trademark of Dries Buytaert.