Download & Extend

Text fields with quicktags appear with wrong titles

Project:quicktags
Version:5.x-3.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:tcblack
Status:closed (fixed)

Issue Summary

Only the first letter of the title shows.

I changed line 154 of quicktags.module from this:
return theme('form_element', $element['#title'], $html, $element['#description'], $element['#id'], $element['#required'], form_get_error($element));

to this:
return theme('form_element', $element, $html);

and the textfields work as expected.

Comments

#1

Status:active» needs review

Needs a proper patch, fortunately this one was easy to make.

AttachmentSize
quicktags.module.title-fix.patch 608 bytes

#2

Assigned to:Anonymous» tcblack

I've also tested the patch and it works as advertised. Let's get some more tests on this one and let me know if anyone experiences any unexpected problems.

I've also marked the following issues as duplicates of this one.

#3

Tried the patch on $Id: quicktags.module,v 1.21 2007/02/03 10:59:25 ber Exp $ downloaded today, seems to be working fine

#4

works fine for me.

#5

I Can't patch with my ISP, but I did make the above code substitution in v1.21.4.1 and it now works as expected.

#6

Version:5.x-2.x-dev» 5.x-3.x-dev
Status:needs review» reviewed & tested by the community

'Applied' manually, but the fix seems to do what it says on the tin.

#7

This is committed and fixed in 5.3

#8

Status:reviewed & tested by the community» fixed

#9

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

nobody click here