Specific language code is unnecessary for link to PHP Manual. It will lead to their language page, if specific language code is not specified.

CommentFileSizeAuthor
#4 php.net-manual.patch6.32 KBlilou
#3 PATCH_HEAD_AUG_26_2008---SYSLOG_INCLUDES_LOCALIZED_URL---ROBIN_MONKS.patch2.61 KBrobin monks
syslog.patch.txt3.63 KBTakafumi

Comments

keith.smith’s picture

keith.smith commented

Both the current and the proposed new links work ok for me, and return what appears to be the same page. I'm sure there is some difference between them, but I don't immediately notice what it is.

@Takafumi: Can you elaborate on why the new string is necessary given that changing the link will invalidate the string for translators?

Takafumi’s picture

Takafumi commented

When accessing to manual/en/foo, page will be displayed in English.
But, if accessing to manual/foo, page will be automatically redirected, and be displayed in visitor's language(HTTP_ACCEPT_LANGUAGE).

robin monks’s picture

robin monks commented
Version: 6.0-rc2 » 7.x-dev
StatusFileSize
new PATCH_HEAD_AUG_26_2008---SYSLOG_INCLUDES_LOCALIZED_URL---ROBIN_MONKS.patch2.61 KB

This issue still exists in HEAD. I doubt it would be backported to 6.x due to translation issues, but +1 on getting this fixed for 7.x.

Re-rolled this patch for 7.x, requesting review.

Robin

lilou’s picture

lilou commented
Title: Wrong link on syslog help » Localized URL for php.net/manual links
Component: syslog.module » user interface text
StatusFileSize
new php.net-manual.patch6.32 KB

Affected files :

  • modules/color/color.install
  • modules/color/color.module
  • modules/syslog/syslog.module
  • sites/default/default.settings.php
robin monks’s picture

robin monks commented
Status: Needs review » Reviewed & tested by the community

Applied clean and everything looks good.

RTBC!

Robin

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

robin monks’s picture

robin monks commented

Thanks Dries!

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.