Posted by greggles on January 12, 2008 at 11:03am
| Project: | S5 presentation player |
| Version: | 6.x-1.x-dev |
| Component: | Code - s5_textfield |
| Category: | feature request |
| Priority: | normal |
| Assigned: | hackwater |
| Status: | needs review |
| Issue tags: | Libraries |
Issue Summary
Different themes may specify their own outline.css or print.css file so the theme selection code should probably 1) check if the theme specific file exists 2) if so, use it, if not, use default
This may also require some sensing/warning on the admin/settings page to alert people to the problem.
Comments
#1
A crude attempt at providing some of this functionality: I added radio buttons to the Admin page to allow a user to override the default behavior of using only the slides.css file in their theme and the remainder the files in the "default" s5 theme. If they choose to override, the template's paths to the stylesheets and Javascript file change from "default" to whatever their theme is called.
All this was done in the s5_textfield.module, but probably can be easily applied to the s5_book.module if desired. There does seem to be some code duplication between the two modules; perhaps it can be abstracted to an admin.inc file? It does seem like a bad idea to share settings in the two modules, in case people want to use the two at the same time...
Also, I would love to change the form element title "Display of S5 Exported Books" to "Display of S5 Presentations", since the s5_textfield.module is not doing exported books, but that's a minor nit.
#2
#3
Been doing some thinking on this topic. It seems the best way to go forward is to use the Libraries API; best practice would keep both Eric Meyer's s5 code as well as any custom themes outside of the module code.
Of course, this paves the way for supporting other/similar presentation libraries besides s5 (s6, s9, FullerScreen, &c.), which would make the module a generic "presentation player" module, using a presentation theme template that can be overridden. All speculation at this point, and potentially messy, but nevertheless, Libraries API seems the way to go, at least for multiple themes.