Work in Progress - Port to Drupal 6

I'm not even sure Lee is maintaining the module anymore. I had a brief e-mail message in December letting me know he was on vacation until 1/5, but I've heard nothing since.

Hi Lee,

I do hope you'll update this module. It's my block to upgrading to Drupal 6.x. I am not sure what you would charge, but I am willing to pay something to have this module updated.

Thank you

I have updated the module for D6. Contact me if you have time to help with testing.

I'm not ready to move to Drupal 6, but I'd like to see the current HEAD version split into 4.7 and 5 versions.

*subscribing*

Find attached the update of the module for D6. Post your comments here with issues you encounter.

Great! :) Thank you so much!

Another update. Report if you see issues.

Seems to work OK here, so far, with Drupal 6.

Oh, not quite. All the calls to the watchdog() function need to be updated as defined here: http://drupal.org/node/114774#watchdog_parameters

And we need to replace mysql_insert_id() with db_last_insert_id('lm_paypal_ipns','id') - this makes the code work with mysqli too, so we can update the lm_paypal.install file to create the lm_paypal_ipns table too.

And the e-mail sending needs some work, as the drupal_mail() function now works quite differently...

And a change to lm_paypal_subscriptions_user():

    $account->content['subscriptions'] = array(
    '#type' => 'user_profile_category',
    '#title' => t('Subscriptions'),
    '#weight' => 6, // under History which is 5.
    );
    $account->content['subscriptions']['subs'] = array(
    '#type' => 'user_profile_item',
    '#title' => t('Current subscription status:'),
    '#value' => $output,
    );
      
    /*$sitems [] = array(
      'title' => '',
      'value' => $output);
      */

    //$ret_subs = array(t('Paypal Subscriptions') => $sitems);

    //return $ret_subs;

And while we're in lm_paypal_subscriptions.module, this line:

$unsuburl = "https://$_lm_paypal_host/cgi-bin/webscr?cmd=_subscr-find&alias=$alias";

should read:

$unsuburl = "https://$_lm_paypal_host/cgi-bin/webscr?cmd=_subscr-find&alias=$alias";

i.e. HTML entity is needed for the & in the URL.

Anthony,

Did you make the updates you have mentioned? If so, can you please attached an archive with the updated module? It is greatly appreciated.

Regards,
Ivan

Here's what I've got so far. It still needs work and testing, the mail function probably needs some re-arranging...

Glad to see y'all are continuing to work on this. The latest from Lee (last month) was:

I'm really swamped for the foreseeable future on a commission. If I do find
time I can probably look at adding features to the subscriptions module.
...
I'm sorry this all sounds so negative but my spare time suddenly vanished
when a rush project came in.

I'm sponsoring some Ubercart modules to provide PayPal Subscriptions and Buy Now functionality. Hopefully they'll be ready to go next month.

Don

does any one know whether i m getting ipns on subscription??
as far as i know there are two entries are made to database one for payment and one for subscription..in the subscription entry i m not getting ipns.

Thanks and regards,

I tried it with a subscription (that is the only paypal option I will have on my site), and it seemed to work fine.

Hey guys, thanks for your hard work on this module.

Trying to get it setup on a D6 install at the moment. At a high level, the module 'works', but a few bugs:

- The installation script appears to skip the creation of a few tables. From the 'LM PayPal Saved IPNs page':

    * user warning: Table 'db.lm_paypal_ipns' doesn't exist query: SELECT COUNT(*) FROM lm_paypal_ipns in /home/site/site/drupal/sites/all/modules/lm_paypal/lm_paypal.module on line 1085.
    * user warning: Table 'db.lm_paypal_ipns' doesn't exist query: SELECT id, timestamp, txn_type, custom FROM lm_paypal_ipns ORDER BY timestamp DESC LIMIT 0, 50 in /home/site/site/drupal/sites/all/modules/lm_paypal/lm_paypal.module on line 1085.

- The creation and management of susbscription packages appears to work fine, and the process of the user selecting to subscribe and being returned to the site works fine, though the user is never assigned the correct roles according to the configuration. The new subscription also does not appear in the list of subscriptions.

I'll probably start digging into this code now, but wanted to see if anyone has run across these and / or written fixes.

Thanks!

Oh, snap. Ok, so copying the lm_paypal.install SQL worked fine for fixing the non-existent table.

Also, I had neglected (well, forgot to have Help module on) to read the help info about setting IPN notifications on my PayPal account. Once I did this, everything works perfectly! Awesome!

Hi! What is the progress in porting this module to D6?
I'm ready to help in testing, debug and code contribution. Can you please attach the latest available version in 6.x compatible branch with the instruction. Thanks!

hi there! i am also interesting in helping with testing, if this is running on 6.x... i am most interested in paying for subscriptions via paypal. can anyone let me know what the most current release is, and where to get it?

cheers
Peter 'Fish' Fisera
GoatVirus Technologies
http://goatvirus.com

#16 has the latest D6-compatible version. The maintainer has dropped this project for the foreseeable future.

thanks mrtoner! will try it out and see what happens.

subscribing... much appreciated!

Subscription doesn't works for me.

It processes the payment and just redirects from PayPal to Thank You page on my site.

But it doesn't upgrades the member to desired role.

Possibly I don't understand the "roles upgrading" mechanism. Can anybody explain am I doing something wrong?

Thanks

update: i have installed this module (from comment #16, as recommended by mrtoner) and so far, everything seems to be working just fine! haven't actually put through a paypal transaction yet :-) but the rest of it seems very solid. i will post another update with a final verdict. looking good so far.

cheers
Fish

Yeah! It works for me too, but the issue I have is upgrading the member's role after PayPal payment.

See details in post #28. Can somebody explain how can I upgrade membership role after paying via PayPal because it look like this functionality doesn't work? Or I still can't understand how it works... Thanks!

I'm now working on finishing this port (using schema API, cleaning up to coding standards, looking at coder module suggestions, removing legacy stuff, etc)

Here's an updated lm_paypal.install that uses the schema API.

Hi
I have got the latest version of lm_paypal module. But I am not able to configure it properly(or may be I am missing something). I am not getting the Paypal buttons and any configuration options related to that. Can anyone help me in this regard.

lm_paypal doesn't provide much interface itself. You need one of the other modules like lm_paypal_donations, lm_paypal_subscriptions or lm_paypal_paid_adverts. Unless you're talking about bugs with the Drupal 6 port in this issue, please create a separate issue if you have other questions/problems.

Success! I have the lm_paypal and lm_paypal_subscriptions working just fine, didn't actually have to fix any bugs, the code posted above (comment #16) seems stable without any changes. I have been on other projects for the last two weeks, didn't have time to do any work on this until now.

One word of caution: when testing, the Paypal developer's sandbox says that IPNs must be posted back to the Paypal host at https://www.sandbox.paypal.com/cgi-bin/webscr (see https://www.paypal.com/IntegrationCenter/ic_ipn.html ) and then to replace this with https://www.paypal.com/cgi-bin/webscr when you actually go live. So you would think that one of these two URLs is what you would enter in the "LM Paypal Host" text field in the LM PayPal IPN Settings page (at admin/lm_paypal_settings). However, what you actually enter is the host name only (ie: https://www.sandbox.paypal.com or https://www.paypal.com ) because the /cgi-bin/webscr is HARDCODED in the LM_Paypal module (if Paypal ever changes this URL, all hell will therefore break loose! :-)) This little oversite cost me a few frustrated hours, so I thought I'd save you all from that same mistake.

webdevbyjoss - are you saying that you have defined a subscription, and you put a valid role into the "Subscriber's Role" field, (I assume you have the "Subscription Kind" field set to "role"?) but then a subscription instance successfully created by this module (from a Paypal payment) is NOT assigning the current user to that role? Because it is working fine for me!

Are you totally sure that the subscription is actually being created? if you go to admin/lm_paypal/subscriptions, and then click on the "subscribers" link on the subscription you are using (at far right), are you then (on page admin/lm_paypal/subscribers/1, or whatever the id of your subscription is) seeing a row to show that user's subscription?

cheers
Fish

Hi guys,

Okay! After a few days of work on this module, I finally got it to work right for all the links & forms & situations I tried. And there were many that were still somewhat wrong for D6.

There are so many changes that I don't even offer a patch, I just created a complete tarball with my current version.

There may be a few things that some people do not like, but it sure includes many fixes (such as a working paid adverts module! Yes, the previous version offered here did not include a way to pay for a node...)

Let me know if you run into problems, I may have time to look into it.

Thank you.
Alexis

AlexisWilke: This looks very interesting. Some fields have changed size from the D5 version. Was this deliberate? See lmpaypal_schema_changes.txt

Everyone else: how have people been going with the version posted in #16? (which is what I was using) It seems like the delay in getting a D6 version into CVS has caused a fork here. I now have commit access, and want to get one of these two versions into CVS this week (ie: before Oct 20th). Even if it's not perfect, we can work on a -dev release on a Drupal 6 branch *together*.

lyricnz,

I prefer #36. 9-)

Note that there are things that simply do not work in #16, specifically, the paid_adverts would not work at all in #16. And just to mention... I started with #16.

I'm not too sure how Drupal handles MySQL or Postgresql, but in D6 you now describe a schema and give sizes as tiny, small, normal and big (more or less). See the .install file for more info (and the paid advert .install is broken in #16) The system then decides of the size in the database. So it can look different in the database itself. Makes sense to me.

I did not test the donation module however, so far I did not have a need. 8-}

If you are interested, I can generate a diff between both versions. Also, I guess so can you!

Thank you.
Alexis Wilke

Thanks for your reply Alexis. I didn't know that you started from the version in #16 - this makes things clearer. I understand about Schema - I wrote a schema in #32 above (before I discovered, and extended, Schema module). See attachment for more specific comments/questions. Does anyone else have feedback about the version alex included in #36?

lyricnz,

I do not pretend that my fixes were correct. So I do not see any problem in having you apply the fixes you mention.

I checked your comments and I did not see anything that I have done on purpose. So it is okay if you want to go ahead and fix my schema.

I had found the one in #32, but I think the reason why I did not use it is because I already had mine for that module (I had fixed all the schemas at once). So I started with #16, but since I had a few fixes for lm_paypal.module, I also quickly applied those to your version. I had no fixes (other than the schemas) to the other modules.

Thank you.
Alexis

Thanks for the excellent work guys! I have just branched for Drupal 6, and committed #36 with some updates for Schema API. Please let me know how it goes (by raising issues, with patches :). See http://drupal.org/cvs?commit=146072

Drupal and you guys who write these modules are amazing! subscribes

Thanks everybody for new version. I'm testing it now in my current project and will get back soon with the update.

I'm receiving
Parse error: syntax error, unexpected T_STRING in /home/bsexpert/public_html/dev/sites/all/modules/lm_paypal/lm_paypal_subscriptions.module on line 70

if I try to enable "lm_paypal_subscriptions" module in Drupal management area.

Parse error in "LM PayPal Subscriptions" module fixed.
Please review the updated version:

This looks like an issue that was fixed very soon after it was committed - please download a newer -dev version of LM Paypal (check the date). For future reference: please open a new ticket if you find an issue, and submit a patch rather than the whole module. See http://drupal.org/patch/create. Alternatively, describe the code you changed, and include just that in your issue.