Convert panel features without UUIDs to use new UUID schema for translatability [#2093405]

Most panel pages are showing up as overridden because they have UUID embedded in them, despite the fact that UUID doesn't exist in our makefile nor is installed with commons.

It seems like we could just pull out the UUID patches, because we haven't had any issues with them thus far. Also, enabling UUID causes other headaches for site builders, and we would have to delete and re-apply the feature if we wanted the overrides to go away. Panel pages that have already been created have been assigned machine names, and features won't touch those.

Comment	File	Size	Author
#4	2093405-uuid-needed-features-4.patch	22.29 KB	japerry

Comments

Comment #1

ezra-g commented 20 September 2013 at 15:19

Title:

Panel pages have UUIDs contained within them, but UUID module doesn't exist

» Feature won't revert: Panel pages have UUIDs contained within them, but UUID module doesn't exist

I believe this was introduced with #2066869: Add panels translation support.

Comment #2

ezra-g commented 20 September 2013 at 15:25

Status:

Active

» Needs review

The patch for this issue is actually at https://drupal.org/node/2086905#comment-7879555.

Comment #3

japerry

KOMK

commented 20 September 2013 at 18:08

Title:	Feature won't revert: Panel pages have UUIDs contained within them, but UUID module doesn't exist	» Convert panel features without UUIDs to use new UUID schema
Status:	Needs review	» Needs work

After talking to Devin and Ezra, this issue has somewhat turned opposite. There are a bunch of features without UUIDs that need them, which is necessary for internationalization.

Comment #4

japerry

KOMK

commented 20 September 2013 at 19:12

Status:

Needs work

» Needs review

Status	File	Size
new	2093405-uuid-needed-features-4.patch	22.29 KB

Here are the UUID added features, its for commons_events_solr and commons_search_solr. The rest already use UUIDs

Comment #5

ezra-g commented 20 September 2013 at 19:18

+++ b/modules/commons/commons_search/modules/commons_search_solr/commons_search_solr.strongarm.inc
@@ -20,6 +20,16 @@ function commons_search_solr_strongarm() {
   $strongarm = new stdClass();
   $strongarm->disabled = FALSE; /* Edit this to true to make a default strongarm disabled initially */
   $strongarm->api_version = 1;
+  $strongarm->name = 'custom_search_other';
+  $strongarm->value = array(
+    'apachesolr_search' => 'apachesolr_search',
+    'user' => 'user',
+  );
+  $export['custom_search_other'] = $strongarm;
+
+  $strongarm = new stdClass();
+  $strongarm->disabled = FALSE; /* Edit this to true to make a default strongarm disabled initially */
+  $strongarm->api_version = 1;
   $strongarm->name = 'page_manager_search_disabled_apachesolr_search';
   $strongarm->value = TRUE;
   $export['page_manager_search_disabled_apachesolr_search'] = $strongarm;
@@ -30,33 +40,22 @@ function commons_search_solr_strongarm() {

@@ -30,33 +40,22 @@ function commons_search_solr_strongarm() {
   $strongarm->name = 'pm_existing_pages_disabled_solr_search';
   $strongarm->value = FALSE;
   $export['pm_existing_pages_disabled_solr_search'] = $strongarm;
-  
+
   $strongarm = new stdClass();
   $strongarm->disabled = FALSE; /* Edit this to true to make a default strongarm disabled initially */
   $strongarm->api_version = 1;
   $strongarm->name = 'search_active_modules';
   $strongarm->value = array(
     'apachesolr_search' => 'apachesolr_search',
-    'user' => 'user',
   );
   $export['search_active_modules'] = $strongarm;
-  
+
   $strongarm = new stdClass();
   $strongarm->disabled = FALSE; /* Edit this to true to make a default strongarm disabled initially */
   $strongarm->api_version = 1;
   $strongarm->name = 'search_default_module';
   $strongarm->value = 'apachesolr_search';
   $export['search_default_module'] = $strongarm;
-  
-  $strongarm = new stdClass();
-  $strongarm->disabled = FALSE; /* Edit this to true to make a default strongarm disabled initially */
-  $strongarm->api_version = 1;
-  $strongarm->name = 'custom_search_other';
-  $strongarm->value = array(
-    'apachesolr_search' => 'apachesolr_search',
-    'user' => 'user',
-  );
-  $export['custom_search_other'] = $strongarm;
 
   return $export;

Are these changes intentional?