This seems to be a different issue from the one fixed in http://drupal.org/node/208635

It seems that the Drupal 5.6 + geshifilter 2.4 + geshi 1.0.7.20 are no longer generating the necessary span elements to style keywords.

Filters are, from lightest to heaviest, HTML, line break, URL, GeSHi.

I will try Drupal 5.5 + geshifilter 2.4 shortly.

Comments

The Fiddler’s picture

The Fiddler commented
Title: Drupal 5.6 / geshifilter 2.4 don't style code elemnts anymore. » Drupal 5.6 / geshifilter 2.4 don't style code elements anymore.
The Fiddler’s picture

The Fiddler commented

I can reproduce the problem on Drupal 5.5 / geshifilter 2.4 (Drupal 5.5 / geshifilter 2.1 works).

The keywords do no have the 'span' elements around them anymore.

If you need any more testing, please say so :)

aclight’s picture

aclight commented

subscribing

The Fiddler’s picture

The Fiddler commented
Status: Active » Closed (fixed)

This report is a false alarm/user error.

@aclight: try checking the 'status' page, it should show that the database schema needs updating. Do so, and things will go back to normal again.

Closing the bug - if it is still there after updating, I will reopen it :)

aclight’s picture

aclight commented

My database does not need an upgrade, but I have a feeling the bug I'm seeing on my site is a separate problem, so i'll leave this closed for now until I can figure out where it's coming from.

soxofaan’s picture

soxofaan commented

GeSHi filter does not use any database table, but there is a geshifilter_update_1() hook however, but that can't be the source of the problem/solution.

Are you both sure it isn't some caching problem?
Are you still having troubles after clearing the filter cache ("?q=geshifilter/clearfiltercache")?
In my setups (D5.6 + GeSHifilter 5.x-2.x-dev and D6.x-dev + GeSHifilter 6.x-dev) everything seems fine, but I constantly clear my filter cache during testing.

aclight’s picture

aclight commented

Clearing the geshifilter cache as you suggested (as well as clearing all caches using devel) does not fix the problem for me.

soxofaan’s picture

soxofaan commented
Version: 5.x-2.4 » 5.x-2.x-dev
Status: Closed (fixed) » Active

Other suggestions:
Test with an input format with only the GeSHi filter in its pipeline
Try different GeSHi filter settings (div-container/pre-container, inline CSS mode/stylesheet mode, ...)

soxofaan’s picture

soxofaan commented
Status: Active » Postponed (maintainer needs more info)

any new information about this problem?

aclight’s picture

aclight commented

I don't believe I'm having this problem on my site anymore, which is running geshifilter v. 2.6. So either you (accidentally?) fixed the problem between versions 2.4 and 2.6, or it was a configuration problem that I happened to fix, likely by accident.

soxofaan’s picture

soxofaan commented
Status: Postponed (maintainer needs more info) » Closed (fixed)

All right, so this issue can be closed again.