After all the hype you made around this module I finally decided to test it. It looks and works great. However, based on the project/module description I expected something different.

Nevertheless, please update the coding-style according to Drupal Coding Standards, so others are able to understand and contribute to this project. This also includes that PHPdoc comments, inline comments, and content of the always-forgotten text files wrap at 80 chars.

As a starting point, I'm attaching a patch that fixes flexifilter.module, flexifilter.info, and API.txt, along with a better approach for assigning component and condition defaults by using an alternate PHP language construct.
This effort should be continued for the remaining files. However, I will leave this up to you.

CommentFileSizeAuthor
#3 coder.patch35.3 KBdmitrig01
flexifilter-DRUPAL-6--1.cleanup.patch23.78 KBsun

Comments

cwgordon7’s picture

cwgordon7 commented
Assigned: Unassigned » cwgordon7

Funnily enough, I was just working on a general code-cleanup of the module. But thank you for the patch— looks pretty good. It may not still be applicable to HEAD, but I'll definitely look over it.

As to the project/module description— what did you expect it to do? Perhaps the module description could be improved, or else functionality added to the module.

cwgordon7’s picture

cwgordon7 commented
Priority: Critical » Normal

And this probably isn't critical.

dmitrig01’s picture

dmitrig01 commented
Assigned: cwgordon7 » dmitrig01
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new coder.patch35.3 KB

Here's a new version

corsix’s picture

corsix commented
Status: Reviewed & tested by the community » Fixed

applied patch to HEAD

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.