Updated: Comment #0

Problem/Motivation

We introduced the weird "bundle_prefix" concept to support the weirdness that comment.module used to do with regard to bundles. comment.module no longer does this after #731724: Convert comment settings into a field to make them work with CMI and non-node entities

Proposed resolution

Remove the remnants of "bundle_prefix".

API changes

Relative to D7 none, as there was no such general concept in the Entity API.
Relative to HEAD: no more bundle_prefix for entities.

#731724: Convert comment settings into a field to make them work with CMI and non-node entities

CommentFileSizeAuthor
#1 no-more-bundle-prefix.patch2.65 KBtstoeckler

Comments

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Active » Needs review
StatusFileSize
new no-more-bundle-prefix.patch2.65 KB

Here we go.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

+1 rtbc

yched’s picture

yched commented

Way cool. RTBC +1 if green.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

RTBC as per #2 and #3.

fago’s picture

fago
Primary language German
Location Vienna
commented

Great change!

andypost’s picture

andypost
he/him
Primary language Russian
commented

+1 here

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Full of win. I think I'm partially responsible for introducing bundle prefix in the first place so nice to see it ripped out again!

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.