functional test for node_teaser()

Posted by Bevan on January 15, 2008 at 9:42am

3 followers

Issue Summary

The attached test runs a few tests on d6's node_teaser(). It is based on several tests in http://drupal.org/node/180425. This work is sponsored by CivicActions.

It runs 119 tests but 117 of them are run by 3 assert functions in a loop that tests edge cases of node_teaser with varying $size parameters.

Posted by Bevan on January 16, 2008 at 11:40pm

Forgot the patch

Attachment	Size	Status	Test result	Operations
node_teaser.test_.txt	4.82 KB	Ignored: Check issue status.	None	None

Posted by Rok Žlender on January 20, 2008 at 10:08am

Great stuff.
I made few changes to your test.

If there is a reason you left asdlkfj in that var please comment otherwise I'll commit this.

Attachment	Size	Status	Test result	Operations
node_teaser.test	4.91 KB	Ignored: Check issue status.	None	None

Posted by Bevan on January 21, 2008 at 12:46am

'asdlkfj' was a mistake that I had done in demonstrating how unit tests work. thanks for removing it

Posted by beeradb on January 24, 2008 at 4:12am

Status:

needs review

» reviewed & tested by the community

Looking over the test it looks sane. I ran it and everything passed. marking rtbc

Posted by Rok Žlender on January 30, 2008 at 8:25am

Status:

reviewed & tested by the community

» fixed

Committed thanks Bevan and beeradb for review.

Posted by Anonymous (not verified) on February 13, 2008 at 8:31am

Status:

fixed

» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.