Closed (fixed)
Project:
Domain
Version:
5.x-1.0rc4
Component:
Code
Priority:
Critical
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
15 Jan 2008 at 13:50 UTC
Updated:
16 Feb 2008 at 22:01 UTC
It is possible that the hook_url_alter() patch is not needed.
Investigate using http://api.drupal.org/api/function/custom_url_rewrite/5 instead.
Comments
Comment #1
agentrickardIn Drupal 5, it appears that the patch is necessary, since custom_url_rewrite() can only modify the $path element, which results in URLs such as: http://one.example.com/?q=http%3A//example.com/node/3, which is not the desired behavior.
It does appear that custom_url_rewrite_outbound() in Drupal 6 will allow for this feature, since that function takes all the arguments from url(),
http://api.drupal.org/api/function/custom_url_rewrite_outbound/6
Comment #2
agentrickardPerhaps instead of the hook_url_alter() patch, we should backport custom_url_rewrite_outbound?
Comment #3
agentrickardNot without patching that function. custom_url_rewrite_outbound() does not allow us to change the absolute path of the url because it is invoked too late in the url() function.
See http://drupal.org/node/207330
Comment #4
agentrickardTo change this function, we would remove the hook_url_alter() patch, and replace it with this code in url():
And then move the existing domain_url_alter() function to custom_url_rewrite_outbound().
Comment #5
agentrickardNow that this patch is in Drupal 6, I will simply backport this for Drupal 5.
Comment #6
agentrickardCommitted to HEAD.
This changes the INSTALL procedure for the module, but brings Domain in line with Drupal 6 core.
Comment #7
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.