Add back in tab removed in [#1972990] and remove drupal_set_title() in tracker module controllers [#2102487]

Comment	File	Size	Author
#5	2102487-diff-3-5.txt	635 bytes	vijaycs85
#5	2102487-remove-set-title-tracker-5.patch	3.28 KB	vijaycs85
#3	drupal8.removedrupalsettitle.track-3.patch	2.66 KB	ACF

Comment #1

wesleydv commented 4 October 2013 at 14:08

Assigned:

Unassigned

» wesleydv

Assigning

Log in or register to post comments

Comment #2

wesleydv commented 4 October 2013 at 15:08

Status:

Active

» Postponed

This issue is currently blocked by #1972990: Convert tracker_page() to a Controller

Log in or register to post comments

Comment #3

ACF commented 27 October 2013 at 09:28

Title:	Remove drupal_set_title in tracker module controllers	» Add back in tab removed in [#1972990] and remove drupal_set_title in tracker module controllers
Assigned:	wesleydv	» Unassigned
Status:	Postponed	» Needs review

Status	File	Size
new	drupal8.removedrupalsettitle.track-3.patch	2.66 KB

In converting tracker_page to a controller in #1972990: Convert tracker_page() to a Controller the tracker tab wasn't maintained. The way that the new system works the tab can be named seperately of the page title and therefore the drupal_set_title could go. I've added in tests to check the title and tab is being set correctly.

Log in or register to post comments

Comment #4

dawehner

German

commented 13 November 2013 at 19:47

Issue summary:	View changes
Status:	Needs review	» Needs work

-      // When viewed from user/%user/track, display the name of the user
-      // as page title -- the tab title remains Track so this needs to be done
-      // here and not in the menu definition.
-      drupal_set_title(user_format_name($account));

Do we really want to change the behavior from using the username to just "Track"? For me this feels wrong.
You should set #title on the resulting render array in order to keep the same functionality.

Log in or register to post comments

Comment #5

vijaycs85

London, UK

commented 18 November 2013 at 22:33

Status:

Needs work

» Needs review

Status	File	Size
new	2102487-remove-set-title-tracker-5.patch	3.28 KB
new	2102487-diff-3-5.txt	635 bytes

@dawehner, I guess we are just adding the tab 'Track' here. The title of the page is already handled by TrackerUserTab::getTitle(). Since we are removing drupal_set_title() here, updating the title callback to use new method $user->getUsername()instead of deprecated user_format_name().