Problem/Motivation

The ContentTranslationController uses a variable called 'anonymous', but the variable system will not be available in Drupal 8.

core/modules/content_translation/lib/Drupal/content_translation/ContentTranslationController.php
280 '#description' => t('Leave blank for %anonymous.', array('%anonymous' => variable_get('anonymous', t('Anonymous')))),

Proposed resolution

Convert this variable to CMI, or remove it in favour of standard translation features supported by t()

Remaining tasks

User interface changes

API changes

This is a child of #1775842: [meta] Convert all variables to state and/or config systems

CommentFileSizeAuthor
#3 2102503-3.patch1.02 KBswentel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Category: task » bug

This has been moved to \Drupal::config('user.settings')->get('anonymous'). Should be an easy fix.

As this is just a left-over and was already converted, I'd say this is a bug, not a task.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Priority: Normal » Critical
swentel’s picture

swentel CreditAttribution: swentel commented
Status: Active » Needs review
FileSize
2102503-3.patch1.02 KB

Status: Needs review » Needs work
Issue tags: -Configuration system, -Config novice

The last submitted patch, 2102503-3.patch, failed testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs work » Needs review

#3: 2102503-3.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 2102503-3.patch, failed testing.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs work » Needs review
Issue tags: +Configuration system, +Config novice

#3: 2102503-3.patch queued for re-testing.

swentel’s picture

swentel CreditAttribution: swentel commented

Was broken because of #2057401: Make the node entity database schema sensible - should be good now.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs review » Reviewed & tested by the community

We can think about injection and so on later on I think, let's just get rid of that variable_get().

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Issue tags: +D8MI, +language-content

Add D8MI tags.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Updated issue summary.