Add newlines to theme_item_list
catch - January 16, 2008 - 00:09
| Project: | Drupal |
| Version: | 6.x-dev |
| Component: | theme system |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
IE has serious trouble dealing with display: inline; on elements which don't have newlines between them. More detail here: http://drupal.org/node/199861
So this patch adds them, also makes the markup a bit more readable.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| item-list-newline.patch | 674 bytes | Ignored | None | None |
#1
The line break is missing in a few places. The problem is noticeable in the theme config page where the secondary tabs push into the right sidebar.
The issue is not isolated with IE. Seems to happen in all browsers and it's by design I think. Line breaks only happen when there's a space or any other character. Ends up treating the whole list like a single string with nothing in-between.
Also removes a stray li close tag for blog pages found when looking into this issue so it's included.
#2
dvessel: that's quite possible, I ran into this combined with IE not supporting :after - which would insert some whitespace, so it could be all browsers yeah. Thanks for looking into this in more depth, will take a proper look tomorrow.
#3
This is also affecting rtl list items by preventing it from swapping the positioning.
http://drupal.org/node/203260
#4
Subscribe
#5
Verified - patching Drupal 6.0 RC2 solved the RTL issue.
Amnon
-
Professional: Drupal Israel | Drupal Development & Consulting | Eco-Healing | Effective Hosting Strategies | בניית אתרים
Personal: Hitech Dolphin: Regain Simple Joy :)
#6
Looks good, thanks Amnon for validating. Committed.
#7
Gábor, there were other issues with RTL. Although this patch fixes wrapping problems, rtl gets a lot stranger.
#8
Automatically closed -- issue fixed for two weeks with no activity.