Add newlines to theme_item_list

Posted by catch on January 16, 2008 at 12:09am

Issue Summary

IE has serious trouble dealing with display: inline; on elements which don't have newlines between them. More detail here: http://drupal.org/node/199861

So this patch adds them, also makes the markup a bit more readable.

Attachment	Size	Status	Test result	Operations
item-list-newline.patch	674 bytes	Ignored: Check issue status.	None	None

Comments

#1

Posted by dvessel on January 16, 2008 at 1:06am

The line break is missing in a few places. The problem is noticeable in the theme config page where the secondary tabs push into the right sidebar.

The issue is not isolated with IE. Seems to happen in all browsers and it's by design I think. Line breaks only happen when there's a space or any other character. Ends up treating the whole list like a single string with nothing in-between.

Also removes a stray li close tag for blog pages found when looking into this issue so it's included.

Attachment	Size	Status	Test result	Operations
item-list-linebreak.patch	2.24 KB	Ignored: Check issue status.	None	None

#2

Posted by catch on January 16, 2008 at 1:16am

dvessel: that's quite possible, I ran into this combined with IE not supporting :after - which would insert some whitespace, so it could be all browsers yeah. Thanks for looking into this in more depth, will take a proper look tomorrow.