Download & Extend

Module calls a views function which it shouldn't

Project:Views Tagadelic
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:active

Issue Summary

Lines 75 and 76 of tagadelic_views.module call _views_replace_args(), a private function in Views, which has been removed in dev.

Comments

#1

views_alpha_pager also does this. Both modules need to be fixed and this also impacts #143888. Do we know if there's a replacement function, or does this just not need to be done anymore?

#2

Status:active» fixed

This tagadelic_views instance of this bug has been resolved, by request to its developers, in release 5.x-1.1 on 2010-Apr-28.

#3

Priority:critical» normal
Status:fixed» active

There seems to be a problem in this new release: While it works fine with views 5.x-1.7 (in which the function _views_replace_args does not exist any longer) there is an error 500 (internal serer error) with views 5.x-1.6, where the function _views_replace_args still exists in the views_query.inc.

There seems to be a problem with function_exists('_views_replace_args') because this statement returns FALSE though the function is defined.

My suggestion is to rename _views_replace_args to tagadelic_replace_args and handle it as an internal function of tagadelic_views.