I don't mean to be picky but I have been looking at the code for this and the other Drigg modules and I would like to help out but some of the code is a bit hard to read. I am volunteering to run the module through Coder module and return a version that meets the drupal coding standards...

CommentFileSizeAuthor
#6 extra_voting_forms.module.patch59.87 KBjaydub
#6 extra_voting_forms.module.txt46.7 KBjaydub
#5 comment_bury_promote.module.patch19.7 KBjaydub
#5 comment_bury_promote.module.txt16.87 KBjaydub
#2 user_karma.module.txt25.45 KBjaydub
#2 user_karma.module.patch879 bytesjaydub

Comments

mercmobily’s picture

mercmobily commented

Hi,

Help is _most_ welcome.
I would be totally, 100000% happy to freeze development for 2 days, to give you time to create the patches

I thought I followed the coding standard, but I have obviously missed a lot.

Please let me know -- I am here.

Merc.

jaydub’s picture

jaydub commented
StatusFileSize
new user_karma.module.patch879 bytes
new user_karma.module.txt25.45 KB

attached the cleaned up module and a patch file.

This includes the small patch from http://drupal.org/node/210609

mercmobily’s picture

mercmobily commented

Hi,

OK, done.
Thank you so much for your help!
I am not creating a new version of the module because we are talking about more changes here: http://drupal.org/node/211074 (again, _THANKS_!)

Now... I don't suppose you would by any chance have time to do the same for drigg and for extra_voting_forms ...?

If not, that's totally fine. But, I thought I'd ask...

Bye!

Merc.

P.S.
You are the first person who has ever helped me with code.

jaydub’s picture

jaydub commented

If you can point me to the latest releases for your other modules -if the latest version is not available on the drupal project page- then I can go through those modules too. You have extra_voting_forms and comment_bury_promote right?

It's already friday in my timezone so if you check this reply out soon, let me know and I can try and go through those modules before the end of my week :)

by the way, happy to help out with coding. It's what open source is all about...Of course it helps that we have a need for the functionality in these modules.

jaydub’s picture

jaydub commented
StatusFileSize
new comment_bury_promote.module.txt16.87 KB
new comment_bury_promote.module.patch19.7 KB

Here is coding standards clean comment_bury_promote module. I have not looked closely at the code for other than coding standards stuff.

jaydub’s picture

jaydub commented
StatusFileSize
new extra_voting_forms.module.txt46.7 KB
new extra_voting_forms.module.patch59.87 KB

I took a quick pass at extra_voting_forms as well. That's quite a big module...

mercmobily’s picture

mercmobily commented

Hi,

Just to make sure: I can just get the "txt" version of the module you updated... since you modified the DRUPAL-5 branch. Is that right?

(I want to avoid reintroducing fixed bugs, and diffing is effectively impossible...)

Bye,

Merc.

mercmobily’s picture

mercmobily commented

Hi,

OK, _all_ applied.

It was a bit of a nightmare to update comment_bury_promote, because it had changed it a little since your patch. However, I re-applied the rejected bits by hand, all good now.

Bye,

Merc.

mercmobily’s picture

mercmobily commented
Status: Active » Closed (fixed)