Posted by jonathan_hunt on January 17, 2008 at 4:49am
| Project: | Reroute Email |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Thanks for this useful wee module. At present, the only way to disable rerouting is to disable the module. I suggest some text to this effect and a link to the admin/build/modules page should be shown on the settings form. If you want a patch I can probably make one.
Comments
#1
Here is another way: a check box in the settings can do that. So, you visit the settings page for this module, and select whether it is active or inactive. This allows it to work on not without disabling the module.
#2
Needed this functionality. So I created a patch against the D6 dev version.
Patch attached for further review.
#3
I like this feature.
It would make it possible to enable/disable rerouting emails via a $conf variable in settings.php; so you can reroute all mails while developing, and turning of rerouting while on Prod (without having a different installation on dev and prod)
#4
@netsensei, the patch you posted does not apply.
Hunk #1 FAILED at 3.
Hunk #2 FAILED at 35.
@Jo Wouters, I like your idea (using settings.php $conf['reroute_email_enable'] = 1). It can be combined with netsensei's patch. It is up to the site admin to do it from the web interface or from settings.php.
#5
@kbahey:
Does work for me though. I checked out the latest CVS (head) version of your code, made my changes there and composed them into a patch.
If I revert my changes and apply the patch on a fresh copy of the head version of the module, it works without any problem.
The command I use:
$ patch enable-disable.patch reroute_email.module#6
Don't make it against HEAD. That is in an unknown state and not maintained until we move to D7.
Use the CVS tag DRUPAL-6--1 and patch against it.
#7
New attempt: I've checkout DRUPAL-6--1 and made patch against that version.
Patch attached.
#8
Committed.
Thank you.
Added README.txt instructions on how to use it from settings.php.
Should be in the -dev tarball in about 9 hours from now.
#9
Automatically closed -- issue fixed for 2 weeks with no activity.