Inserts RSS Feed tags that don't validate
ismyrnow - January 17, 2008 - 05:39
| Project: | FlashVideo |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | attheshow |
| Status: | closed |
Description
When module is enabled, RSS Feed does not validate on www.feedvalidator.org because of two lines in each item.
The feed is generated on nodes using the Views module and Audio module. Specified nodes do not have embedded flash videos, therefore do not make use of the module, but enabling the module inserts these lines automatically.
<enclosure url="http://www.ideasunleashed.org/drupal/files/" length="4096" />
<media url="http://www.ideasunleashed.org/drupal/files/" fileSize="4096" type="" />The enclosure tag needs a type, and the media tag is unidentified, and neither is necessary for these particular node items.
Perhaps these lines could be left out of a feed if they're not needed for the specific nodes.
#1
Subscribing.
#2
Do you have an exact URL that I can take a look at to see what you mean? I might be able to fix it if I have a real life example.
Thanks,
Travis.
#3
go change it in the module yourself...
#4
Hi,
The RSS code that I see in version 5.x-2.0 looks very broken to me. It doesn't properly check to see whether there is actually a video attached to a node before it inserts the media tags. It looks to me like a database query is made in the 'case rss' section of the flashvideo_nodeapi function, but then the results aren't correctly loaded into any variable, nor are any checks made for whether there is a video or not.
It doesn't look like a lot of work to fix this, but I'm not that familiar with the module or with Drupal's RSS feed API. In any case, I don't really care if videos show up correctly in my RSS feeds. I'm attaching a patch that simply disables the RSS functionality of this module. It doesn't fix its RSS support, but it will prevent the module inserting those tags which lead to invalid RSS.
#5
LOL, nice patch, thanks :)
Actually simple check could easily be made.
#6
Fixed in version 6.x. We needed a break; statement. Also, I've set it to where this code only runs if you're NOT use the FileField integration. ...since CCK gives you the option of what you want to display in your RSS output.
#7
Automatically closed -- issue fixed for 2 weeks with no activity.