There are other things wrong with this function (like it doesn't actually retrieve a list of categories, seemingly) but here's at least one obvious bug that was revealed by boombatower in his GHOP SimpleTest work.

CommentFileSizeAuthor
#1 blogapi-taxonomy-wrong-params-211067.patch929 byteswebchick

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Title: BlogAPI still calling taxonomy_node_get_terms with old arguments » blogapi_mt_get_post_categories is broken
StatusFileSize
new blogapi-taxonomy-wrong-params-211067.patch929 bytes

Here's a patch to fix that problem.

I'm wondering if this should be elevated to critical, as I imagine this is breaking something somewhere. It's at least spitting out errors when the function is called directly.

Rok Žlender’s picture

Rok Žlender commented

I tested the patch and it fixes the returning terms problem.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs work » Reviewed & tested by the community

Ok, well let's get that in for now, I guess. Sometime when walkah or someone who's touched blogapi before is around, we can look at the function itself.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Indeed, looks logical, thanks, committed.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.