The image gallery (/image) looks fine in Internet Explorer. Using Firefox (on linux OR windows) renders incorrectly. Horizontal images look fine. Vertical images extend beyond the limits of their grey frame.

Comments

Cvbge’s picture

The same happens for me :(

walkah’s picture

what's the CVS version of your image.module? (should be line #2 - paste the whole line, that's fine). latest is 1.146.2.4

I believe this is fixed... if not, could you show a screenshot or demo URL?

Cvbge’s picture

StatusFileSize
new84.37 KB

In the latest DRUPAL-4-6 (1.146.2.4) a page looks like in the file attached. I can provide any further information you need.

I could not test head version, as it did not display anything. I haven't checked why. If you tell me which revision introduced the fix I could try applying the changes to the 4-6 version.

BTW, could you apply patch for configurable number of images on the page? It produces this nice "Images per page:" in admin/settings/image and I can set it to 18 (my favourite number ;))

eafarris’s picture

StatusFileSize
new994 bytes

Try this patch for fixing the gallery display problems. There are some hard-coded dimensions on the li's in the gallery. This removes them. Seems to clear it up for my users.

Cvbge’s picture

Yes! Works nicely!
Thanks :)

Cvbge’s picture

StatusFileSize
new213.97 KB

Not sure if this is connected... but even with this patch there are some problems with variable size thumbnails (I'm using http://drupal.org/node/21158 patch to have more images on page).

Screenshot attached.

Steve Dondley’s picture

StatusFileSize
new137.27 KB

With larger photos, it is quite a mess. See screen shot taken at 1280 x 1024. I'm using version 1.146.2.2 of the image.module

The "image galleries" page, located at /image, was also very messy. I had to modify the themeable output so that each gallery listing got placed into a separate html table.

Bèr Kessels’s picture

I had this problem too, but found out it was my own fault: The sizes of the colums are generated from your thumb settings. If you have thumbs (because they were generated in the past with different settings) that are larger then the settings for thumbs you will get what you show in the screendump.

Could you please have a look if you are not having that problem?

CdnStrangequark’s picture

The patch works...mostly. It still displays incorrectly if you have a gallery which contains both regular images and sub-galleries. The regular images appear outside of the content window. Seems to occur on all mozilla-based browsers (Firefox, Netscape, and nearly all Linux browsers).

cceallen’s picture

StatusFileSize
new1.05 KB

I found the attached patch worked better for me - a variation on the patch given above. Using width settings seems to work in Firefox and IE.

Steve Dondley’s picture

StatusFileSize
new202.36 KB

Check the screenshot:

1) columns way to narrow, especially for pics with long titles
2) page navigation runs into row of pictures

Are we sure CSS is the right thing to do here? Why not tables?

Bèr Kessels’s picture

AFAIK tghis was fixed two weeks ago, by removing that specific CSS in the LI's.

And no, tables are for tabular data. You will need a huge amount of code to render them right (columns etc). And on top of all that, tables break CSS layouts very badly.

a biiiig -1 on tables.

Robrecht Jacques’s picture

Agreed, a big -1 on tables.

BTW Ber: the removal of style="width: ..." hasn't been applied yet. And that fix was for the display of a list of galleries, not a list of the photos itself (see: http://drupal.org/node/25054 - similar patch as the one of comment 4 here).

Maybe: http://accessat.c-net.us/test/gallery2.html ("Centered CSS Image Gallery") is a solution. That CSS seems to work in most browsers. Only downside is that a couple of "CSS Hacks" are needed to render it correctly in "all" browsers.

I'll look into it later today.

Steve Dondley’s picture

I am using the very latest version of the module from the 4.6.0 branch. This has not been fixed. If it has, it needs to be backported from HEAD.

ezheidtmann’s picture

StatusFileSize
new40.42 KB

The "Centered CSS Image Gallery" has problems with overflowing text in my Firefox 1.0.4 on Debian. Screenshot attached.

Bèr Kessels’s picture

CSS iwill always have itc certain problems.
Rob, indeed, it was a different issue that was fixed.
All, please have a look at shazamgallery (http://cvs.drupal.org/viewcvs/drupal/contributions/sandbox/ber/shazamgal...) and see isf that gets closer to you needs. if not, please give me feedback (and patches!!) on what you'd like to see changed.

drewish’s picture

Status: Needs review » Fixed

not sure if it got back ported to 4.6 but it's fixed in head and 4.6 is now unsupported.

Anonymous’s picture

Status: Fixed » Closed (fixed)