breadcrumb fix
leop - January 18, 2008 - 14:29
| Project: | Subversion |
| Version: | 5.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
If you are browsing within a certain repository, the id of that repository is missing in the breadcrumb links, resulting in incorrect links. I propose the following fix:
- Change the function
_subversion_breadcrumb($path)into_subversion_breadcrumb($path, $repo) - Luckily the variable
$repois already defined in all calls to_subversion_breadcrumb, so we can change all references_subversion_breadcrumb($path);into_subversion_breadcrumb($path, $repo);. This should be done in functionssubversion_page_browse,subversion_page_fileandsubversion_page_log. - Now that the variable
$repois known in_subversion_breadcrumb, we can easily insert the repository id, by changing$breadcrumb[] = l($title, 'subversion/browse'. rtrim($p, '/'));into$breadcrumb[] = l($title, 'subversion/browse/'. $repo->rid. rtrim($p, '/'));

#1
#2
Automatically closed -- issue fixed for two weeks with no activity.