breadcrumb fix

leop - January 18, 2008 - 14:29
Project:Subversion
Version:5.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

If you are browsing within a certain repository, the id of that repository is missing in the breadcrumb links, resulting in incorrect links. I propose the following fix:

  1. Change the function _subversion_breadcrumb($path) into _subversion_breadcrumb($path, $repo)
  2. Luckily the variable $repo is already defined in all calls to _subversion_breadcrumb, so we can change all references _subversion_breadcrumb($path); into _subversion_breadcrumb($path, $repo);. This should be done in functions subversion_page_browse, subversion_page_file and subversion_page_log.
  3. Now that the variable $repo is known in _subversion_breadcrumb, we can easily insert the repository id, by changing $breadcrumb[] = l($title, 'subversion/browse'. rtrim($p, '/')); into $breadcrumb[] = l($title, 'subversion/browse/'. $repo->rid. rtrim($p, '/'));

#1

halkeye - January 21, 2008 - 05:00
Status:needs review» fixed

#2

Anonymous (not verified) - February 4, 2008 - 05:01
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.